search

uzairfarooq / arrive

Watch for DOM elements creation and removal
MIT License
869 stars 99 forks source link

'this' is not guaranteed to be bound to the window object #41

Closed majames closed 8 years ago

majames commented 8 years ago

3rd time lucky...

Passing in 'this' into the top level closure in arrive.js assumes that it is bound to the browser 'window' object.

It is safer to pass in 'window' object directly because 'this' is not guaranteed to be bound to the window object when arrive.js is used in build tools like gulp, webpack, etc...

uzairfarooq commented 8 years ago

Done :) will be part of next release.

majames commented 8 years ago

Thanks!

vinodc commented 8 years ago

@uzairfarooq Hi. I was wondering when there would be a next release that would include this change. Currently using the dev branch, but it would be great if we could point to a version number for increased stability.

uzairfarooq commented 8 years ago

Thanks for reminder. Will release it on coming weekend.

uzairfarooq commented 8 years ago

Released the new version v2.3.1. The master contains the latest version. Here is the change log https://github.com/uzairfarooq/arrive/releases/tag/v2.3.1

vinodc commented 8 years ago

Thanks @uzairfarooq !