search

uzairkbr / Password-Generator-JavaScript

0 stars 0 forks source link

Revise as per our review #1

Open junaidkbr opened 1 month ago

junaidkbr commented 1 month ago

This is a great start. As per our in-person review, please revise this code and send the PR.

Here's the review session: https://www.loom.com/share/d7437fb39da8413d88aba8156f8bd670

uzairkbr commented 1 month ago

I rewatched the video and noted the following key points to update my code:

1) The .container class is used for layout in Bootstrap, as it has a conventional name. So, using it for styling elements is not a good practise. 2) Ensure classes have meaningful names. 3) Write easily readable code. 4) Avoid using “ID” for styling elements. 5) Add spacing between elements. 6) Only leave comments when the project is functional. 7) Include comments for addEventListener functions.

I tried to assign you as a PR reviewer, but it wasn't possible because you aren't a contributor to my repo.

Here is the PR link: https://github.com/Uzairahmad8/Password-Generator-JavaScript/pull/3

uzairkbr commented 1 month ago

Resolve the issue. please review it and merge the code to master branch.