uzerpllp / uzerp

uzERP - Open Source Business Management
http://www.uzerp.com
Other
53 stars 26 forks source link

Report module not working after upgrade to 1.5.0 #91

Closed steveblamey closed 8 years ago

steveblamey commented 8 years ago
steveblamey commented 8 years ago

Analysis

In 1.5.0 we stopped distributing the adodb-php library with uzERP and moved it to a composer installation. This has caused a regression in the reporting module. Comparing the adodb 5.18 code distributed with uzERP and the source code for 5.18 from sourceforge, it is clear that some undocumented changes have been made by a previous uzERP developer.

Fix

I have created a new git repo, https://bitbucket.org/uzerp/adodb, that contains the modified adodb-php 5.18 version that was originally distributed with uzERP and a composer.json file.

We can then install via composer by adding a repository to uzERP's composer.json file:

#!json

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://uzerp@bitbucket.org/uzerp/adodb.git"
        }
    ],

    "require": {
        ...
        "adodb/adodb-php": "@dev",
        ...
    },

    "autoload": {
        "files" : [
            "vendor/adodb/adodb-php/adodb-xmlschema03.inc.php"
        ]
    }
}

At some point we should consider re-factoring our code to avoid using a forked adodb lib.

steveblamey commented 8 years ago

Our adodb repo needs moving to github now.