search

uzh-bf / klicker-uzh

KlickerUZH Audience Interaction Platform
https://www.klicker.uzh.ch
GNU Affero General Public License v3.0
35 stars 14 forks source link

fix: ensure magic link emails are seeded without .html #4219

Closed rschlaefli closed 2 weeks ago

aviator-app[bot] commented 2 weeks ago

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes. Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.

See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.
coderabbitai[bot] commented 2 weeks ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough ## Walkthrough The project has undergone several modifications, including updates to configuration settings for Prettier, significant changes to functions in the `accounts.ts` file related to email handling and database transactions, the introduction of a new dependency for transactional operations, and restructuring of email template seeding logic. Additionally, there was a removal of a Prisma dependency in the `transactional` package, indicating changes in dependency management. ## Changes | Files | Change Summary | |-----------------------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | `.vscode/settings.json` | Changed Prettier configuration path from `.prettierrc.js` to `.prettierrc.mjs`. | | `packages/graphql/src/services/accounts.ts` | Modified `sendMagicLink` and `createParticipantAccount` functions for better error handling and transaction management. Renamed variable in `sendMagicLink`, adjusted return values, and encapsulated logic within a database transaction. | | `packages/prisma/package.json` | Added `@klicker-uzh/transactional` to `devDependencies`. | | `packages/prisma/src/data/seedEmailTemplates.ts` | Replaced `upsertEmailTemplates` with `seedEmailTemplates`, allowing external PrismaClient usage. Changed output directory path and modified logic for handling email template names. | | `packages/prisma/src/data/seedTEST.ts` | Added import and call to `seedEmailTemplates` in `seedTest` function, enhancing the seeding process. | | `packages/transactional/package.json` | Removed `@klicker-uzh/prisma` from `devDependencies`. | | `packages/transactional/out/MagicLinkRequested.html` | Modified HTML structure and inline styles for improved readability and presentation. | | `packages/transactional/out/ParticipantAccountActivation.html` | Updated CSS styles in the email template to enhance visual presentation and readability. | | `packages/transactional/src/components/Layout.tsx` | Altered properties of `Html` and `Container` components to improve layout consistency and readability. | | `packages/transactional/src/emails/MagicLinkRequested.tsx` | Modified link rendering for improved formatting and readability in the email content. | | `packages/transactional/src/emails/ParticipantAccountActivation.tsx` | Adjusted hyperlink presentation for better readability in the email content. |

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
cypress[bot] commented 2 weeks ago

klicker-uzh    Run #2746

Run Properties:  status check failed Failed #2746  •  git commit 2d2692c3b7 ℹ️: Merge c5b6ef24914cb6b8f320e03e27a3957d87b46eb9 into 2abb1c1ed3410fc08fcfcc9f56b5...
Project klicker-uzh
Branch Review MagicLinkImprovements
Run status status check failed Failed #2746
Run duration 09m 27s
Commit git commit 2d2692c3b7 ℹ️: Merge c5b6ef24914cb6b8f320e03e27a3957d87b46eb9 into 2abb1c1ed3410fc08fcfcc9f56b5...
Committer Roland Schläfli
View all properties for this run ↗︎
Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 37
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/H-practice-quiz-workflow.cy.ts • 1 failed test View Output
Test Artifacts
Different practice quiz workflows > Test creating and publishing a practice quiz Test Replay Screenshots
Flakiness  cypress/e2e/G-microlearning-workflow.cy.ts • 1 flaky test View Output
Test Artifacts
Different microlearning workflows > converts a seeded past microlearning into a practice quiz Test Replay Screenshots
sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

cypress[bot] commented 2 weeks ago

klicker-uzh    Run #2747

Run Properties:  status check failed Failed #2747  •  git commit c75ebe8be7: fix: ensure magic link emails are seeded without .html (#4219)
Project klicker-uzh
Branch Review v3
Run status status check failed Failed #2747
Run duration 09m 55s
Commit git commit c75ebe8be7: fix: ensure magic link emails are seeded without .html (#4219)
Committer Roland Schläfli
View all properties for this run ↗︎
Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 37
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/H-practice-quiz-workflow.cy.ts • 1 failed test View Output
Test Artifacts
Different practice quiz workflows > Test creating and publishing a practice quiz Test Replay Screenshots
Flakiness  F-live-quiz-workflow.cy.ts • 1 flaky test View Output
Test Artifacts
Different live-quiz workflows > creates a live quiz without questions and tests the feedback mechanisms and deletes the completed live session Test Replay Screenshots
Flakiness  K-group-activity-workflow.cy.ts • 1 flaky test View Output
Test Artifacts
Create and solve a group activity > create a group activity and edit it Screenshots