search

uzh-bf / klicker-uzh

KlickerUZH Audience Interaction Platform
https://www.klicker.uzh.ch
GNU Affero General Public License v3.0
37 stars 14 forks source link

fix: ensure that correct data is loaded into wizard for live quiz editing and duplication #4228

Closed sjschlapbach closed 2 months ago

aviator-app[bot] commented 2 months ago

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes. Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.

See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.
coderabbitai[bot] commented 2 months ago
Walkthrough ## Walkthrough The changes involve updates to user-facing messages in a React component and modifications to data handling in another. The `PracticeQuizAccessLink` component's translation string was updated to reflect quiz access more accurately. Additionally, the `LiveSessionWizard` component now retrieves question identifiers by parsing the `id` property as an integer, which may affect data type consistency. Other changes include new test cases and restructuring of imports across various files. ## Changes | Files | Change Summary | |-----------------------------------------------------------------------|---------------------------------------------------------------------------------------------------| | `apps/frontend-manage/src/components/courses/actions/PracticeQuizAccessLink.tsx` | Updated the translation string from `'manage.course.linkPracticeQuizCopied'` to `'manage.course.linkAccessCopied'`. | | `apps/frontend-manage/src/components/sessions/creation/liveQuiz/LiveSessionWizard.tsx` | Changed the extraction of `questionId` to parse `instance.questionData!.id` as an integer. | | `cypress/cypress/e2e/F-live-quiz-workflow.cy.ts` | Added a test case for creating and duplicating a live quiz session, including question management and verification steps. | | `packages/graphql/src/lib/questions.ts` | Removed constants and the `processQuestionData` function, simplifying data handling logic. | | `packages/graphql/src/services/accounts.ts` | Updated import for `processQuestionData` from local module to external utility module. | | `packages/graphql/src/services/questions.ts` | Consolidated imports for question processing functions from external utility module. | | `packages/graphql/src/services/sessions.ts` | Added import for `processQuestionData` from external utility module, removing local import. | | `packages/util/src/index.ts` | Introduced `ExtendedElement` type and modified `processQuestionData` to return this new type. |

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
cypress[bot] commented 2 months ago

klicker-uzh    Run #2802

Run Properties:  status check passed Passed #2802  •  git commit 282f8feb9d ℹ️: Merge 51bb010006072f35bf5abd511e524a89e9d49416 into ee54a9beac69a3a54eceb2c19412...
Project klicker-uzh
Branch Review FixLiveQuizEditingDuplication
Run status status check passed Passed #2802
Run duration 07m 59s
Commit git commit 282f8feb9d ℹ️: Merge 51bb010006072f35bf5abd511e524a89e9d49416 into ee54a9beac69a3a54eceb2c19412...
Committer Julius Schlapbach
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 39
View all changes introduced in this branch ↗︎
sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

cypress[bot] commented 2 months ago

klicker-uzh    Run #2803

Run Properties:  status check passed Passed #2803  •  git commit e027754d2c: fix: ensure that correct data is loaded into wizard for live quiz editing and du...
Project klicker-uzh
Branch Review v3
Run status status check passed Passed #2803
Run duration 08m 23s
Commit git commit e027754d2c: fix: ensure that correct data is loaded into wizard for live quiz editing and du...
Committer Julius Schlapbach
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 39
View all changes introduced in this branch ↗︎