search

uzh-bf / klicker-uzh

KlickerUZH Audience Interaction Platform
https://www.klicker.uzh.ch
GNU Affero General Public License v3.0
37 stars 14 forks source link

enhance(apps/frontend-manage): add back button to activity creation wizards #4253

Closed sjschlapbach closed 1 month ago

sjschlapbach commented 1 month ago
Screenshot 2024-09-08 at 11 56 24
aviator-app[bot] commented 1 month ago

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes. Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.

See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.
coderabbitai[bot] commented 1 month ago
Walkthrough ## Walkthrough The changes across multiple components in the application introduce a new prop, `onPrevStep`, which facilitates navigation to the previous step in a multi-step wizard interface. This prop is added to various components, allowing them to invoke `onPrevStep` with the current values when the user triggers the action to go back. This modification enhances the control flow and user interaction within the wizard. ## Changes | Files | Change Summary | |------------------------------------------------------------------------------------------------|--------------------------------------------------------------------------------------------------------| | `apps/frontend-manage/src/components/sessions/creation/DescriptionStep.tsx` | Added `onPrevStep` prop to handle previous step navigation. | | `apps/frontend-manage/src/components/sessions/creation/StackCreationStep.tsx` | Added `onPrevStep` prop for previous step navigation. | | `apps/frontend-manage/src/components/sessions/creation/WizardNavigation.tsx` | Added optional `onPrevStep` to handle previous step action with a back button. | | `apps/frontend-manage/src/components/sessions/creation/groupActivity/*.tsx` | Added `onPrevStep` prop for handling previous step navigation in multiple group activity components. | | `apps/frontend-manage/src/components/sessions/creation/liveQuiz/*.tsx` | Added `onPrevStep` for previous step navigation in multiple live quiz components. | | `apps/frontend-manage/src/components/sessions/creation/microLearning/*.tsx` | Added `onPrevStep` for previous step navigation in multiple micro-learning components. | | `apps/frontend-manage/src/components/sessions/creation/practiceQuiz/*.tsx` | Added `onPrevStep` for previous step navigation in multiple practice quiz components. | ## Possibly related PRs - **#4108**: Introduces a new prop `onPrevStep` in multiple components related to a multi-step wizard interface, aligning with the main PR's addition of the same prop. - **#4141**: Focuses on database schema changes, indirectly connecting to overall user experience enhancements discussed in the main PR.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed

Failed conditions
6.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

cypress[bot] commented 1 month ago

klicker-uzh    Run #2929

Run Properties:  status check failed Failed #2929  •  git commit 27b932fae9 ℹ️: Merge 1f870e4d93cfbffeb7f6edecf56fa30c89fa9989 into a1c78d633fe4d8ceb3ab2e0b3600...
Project klicker-uzh
Branch Review wizard-back-button
Run status status check failed Failed #2929
Run duration 09m 16s
Commit git commit 27b932fae9 ℹ️: Merge 1f870e4d93cfbffeb7f6edecf56fa30c89fa9989 into a1c78d633fe4d8ceb3ab2e0b3600...
Committer Julius Schlapbach
View all properties for this run ↗︎
Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 42
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/E-course-workflow.cy.ts • 1 failed test View Output
Test Artifacts
Test course creation and editing functionalities > Test the assignment of random groups in the seeded test course Test Replay Screenshots
Flakiness  G-microlearning-workflow.cy.ts • 1 flaky test View Output
Test Artifacts
Different microlearning workflows > converts a seeded past microlearning into a practice quiz Test Replay Screenshots
Flakiness  K-group-activity-workflow.cy.ts • 1 flaky test View Output
Test Artifacts
Create and solve a group activity > create a group activity and edit it Screenshots
cypress[bot] commented 1 month ago

klicker-uzh    Run #2930

Run Properties:  status check failed Failed #2930  •  git commit 67a20f3f20: enhance(apps/frontend-manage): add back button to activity creation wizards (#42...
Project klicker-uzh
Branch Review v3
Run status status check failed Failed #2930
Run duration 09m 55s
Commit git commit 67a20f3f20: enhance(apps/frontend-manage): add back button to activity creation wizards (#42...
Committer Julius Schlapbach
View all properties for this run ↗︎
Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 41
View all changes introduced in this branch ↗︎

Tests for review

Failed  F-live-quiz-workflow.cy.ts • 1 failed test View Output
Test Artifacts
Different live-quiz workflows > creates a live quiz without questions and tests the feedback mechanisms and deletes the completed live session Test Replay Screenshots
Failed  K-group-activity-workflow.cy.ts • 1 failed test View Output
Test Artifacts
Create and solve a group activity > create a group activity and edit it Screenshots
Flakiness  cypress/e2e/G-microlearning-workflow.cy.ts • 1 flaky test View Output
Test Artifacts
Different microlearning workflows > converts a seeded past microlearning into a practice quiz Test Replay Screenshots