search

uzh-bf / klicker-uzh

KlickerUZH Audience Interaction Platform
https://www.klicker.uzh.ch
GNU Affero General Public License v3.0
37 stars 14 forks source link

feat: add possibility to extend microlearnings and group activities before end date #4283

Closed sjschlapbach closed 1 month ago

sjschlapbach commented 1 month ago

With this PR, it is now possible to extend running microlearnings and group activities through a corresponding modal on the course overview.

Screenshot 2024-10-02 at 14 51 16 1
aviator-app[bot] commented 1 month ago

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes. Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.

See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.
coderabbitai[bot] commented 1 month ago
📝 Walkthrough
📝 Walkthrough ## Walkthrough This pull request introduces enhancements to the `GroupActivityElement` and `MicroLearningElement` components by adding functionality to extend the duration of group activities and microlearning sessions. A new `ExtensionModal` component is implemented for this purpose, along with corresponding GraphQL mutations for backend support. Additionally, end-to-end tests are added to verify the new functionality, and localization files are updated to include new keys for the extended features. ## Changes | File Path | Change Summary | |-----------------------------------------------------|-----------------------------------------------------------------------------------------------------| | `apps/frontend-manage/src/components/courses/GroupActivityElement.tsx` | Added `faCalendar` icon, new state variable `extensionModal`, and `ExtensionModal` component. | | `apps/frontend-manage/src/components/courses/MicroLearningElement.tsx` | Introduced `ExtensionModal`, updated dropdown for extending microlearning, and modified status logic. | | `apps/frontend-manage/src/components/courses/modals/ExtensionModal.tsx` | New component for extending end dates of activities, using Formik for form handling. | | `cypress/cypress/e2e/G-microlearning-workflow.cy.ts` | Added test case for extending a microlearning's end date with validation checks. | | `cypress/cypress/e2e/K-group-activity-workflow.cy.ts` | Added test case for extending a group activity's end date with validation checks. | | `packages/graphql/src/graphql/ops/MExtendGroupActivity.graphql` | New mutation `ExtendGroupActivity` for extending group activity end dates. | | `packages/graphql/src/graphql/ops/MExtendMicroLearning.graphql` | New mutation `ExtendMicroLearning` for extending microlearning end dates. | | `packages/graphql/src/ops.schema.json` | Updated schema to include new types and mutations for extending activities. | | `packages/graphql/src/ops.ts` | Added new mutation fields for extending group activities and microlearning. | | `packages/graphql/src/public/client.json` | Added methods for `ExtendGroupActivity` and `ExtendMicroLearning`. | | `packages/graphql/src/public/server.json` | Added server-side support for new mutations. | | `packages/i18n/messages/de.ts` | Updated German localization with new keys for extending activities. | | `packages/i18n/messages/en.ts` | Updated English localization with new keys for extending activities. | ## Possibly related PRs - **#4259**: Modifies course selection logic to include group creation capabilities, relevant to managing group activities. - **#4271**: Introduces messaging functionality within groups, enhancing group activity interactions. ## Suggested reviewers - rschlaefli
📜 Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
đŸ“Ĩ Commits Files that changed from the base of the PR and between 84d685dbf1ec9645a1a0a629035f909e471bc667 and 90ac7123abc200740902bc8b46c5785368c207e1.
📒 Files selected for processing (2) * packages/graphql/src/services/groups.ts (1 hunks) * packages/graphql/src/services/microLearning.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2) * packages/graphql/src/services/groups.ts * packages/graphql/src/services/microLearning.ts
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
❤ī¸ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
đŸĒ§ Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
cypress[bot] commented 1 month ago

klicker-uzh    Run #3089

Run Properties:  status check passed Passed #3089  •  git commit 18d94a17a0 ℹī¸: Merge 90ac7123abc200740902bc8b46c5785368c207e1 into e356d437c8fdc47cf0e96c1273e4...
Project klicker-uzh
Branch Review extend-activities
Run status status check passed Passed #3089
Run duration 09m 59s
Commit git commit 18d94a17a0 ℹī¸: Merge 90ac7123abc200740902bc8b46c5785368c207e1 into e356d437c8fdc47cf0e96c1273e4...
Committer Julius Schlapbach
View all properties for this run ↗ī¸Ž
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 47
View all changes introduced in this branch ↗ī¸Ž
sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed

Failed conditions
3.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

cypress[bot] commented 1 month ago

klicker-uzh    Run #3090

Run Properties:  status check failed Failed #3090  •  git commit 7c84a597a3: feat: add possibility to extend microlearnings and group activities before end d...
Project klicker-uzh
Branch Review v3
Run status status check failed Failed #3090
Run duration 09m 25s
Commit git commit 7c84a597a3: feat: add possibility to extend microlearnings and group activities before end d...
Committer Julius Schlapbach
View all properties for this run ↗ī¸Ž
Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 46
View all changes introduced in this branch ↗ī¸Ž

Tests for review

Failed  cypress/e2e/E-course-workflow.cy.ts â€ĸ 1 failed test View Output
Test Artifacts
Test course creation and editing functionalities > Test the assignment of random groups in the seeded test course Test Replay Screenshots