search

uzh-rpg / DSEC

MIT License
128 stars 16 forks source link

Wrong Compression in Docs #42

Closed klowrey closed 2 years ago

klowrey commented 2 years ago

The docs say that the hdf5 files are compressed with zstd. This is incorrect, at least for interlaken_00_c's left event stream.

$ h5dump -pH events.h5 | grep 'FILTER\|COMMENT'
         FILTERS {
            USER_DEFINED_FILTER {
               FILTER_ID 32001
               COMMENT blosc
         FILTERS {
            USER_DEFINED_FILTER {
               FILTER_ID 32001
               COMMENT blosc
         FILTERS {
            USER_DEFINED_FILTER {
               FILTER_ID 32001
               COMMENT blosc
         FILTERS {
            USER_DEFINED_FILTER {
               FILTER_ID 32001
               COMMENT blosc
      FILTERS {
         USER_DEFINED_FILTER {
            FILTER_ID 32001
            COMMENT blosc
      FILTERS {

This might be critical for folks that want to access such data. Either the documentation should be change or the files re-compressed and uploaded.

magehrig commented 2 years ago

Thanks for the feedback. I updated the docs to reflect that Blosc is used with the ZSTD codec. Let me know if you think it is clear now or if something is missing.