Open francescomilano172 opened 5 years ago
It is not crucial, but should this (and similarly 3planes_simulate.launch) also include <remap from="camera_info" to="/dvs/camera_info" />? https://github.com/uzh-rpg/rpg_davis_simulator/blob/50e84063fffb9de609091df2f77b2ad52c3008fa/launch/3walls_simulate.launch#L21-L26
3planes_simulate.launch
<remap from="camera_info" to="/dvs/camera_info" />
The dvs_renderer listens to the topic camera_info, which is then used (if found) to publish the undistorted image, but the dvs_simulator_py node publishes under /dvs/camera_info: https://github.com/uzh-rpg/rpg_dvs_ros/blob/eb40fb317b3dc1b6ee82127b0cb49a8dfd1d3fe5/dvs_renderer/src/renderer.cpp#L20
dvs_renderer
camera_info
dvs_simulator_py
/dvs/camera_info
https://github.com/uzh-rpg/rpg_davis_simulator/blob/50e84063fffb9de609091df2f77b2ad52c3008fa/src/dvs_simulator_py/dvs_simulator.py#L176
It is not crucial, but should this (and similarly
3planes_simulate.launch) also include<remap from="camera_info" to="/dvs/camera_info" />? https://github.com/uzh-rpg/rpg_davis_simulator/blob/50e84063fffb9de609091df2f77b2ad52c3008fa/launch/3walls_simulate.launch#L21-L26The
dvs_rendererlistens to the topiccamera_info, which is then used (if found) to publish the undistorted image, but thedvs_simulator_pynode publishes under/dvs/camera_info: https://github.com/uzh-rpg/rpg_dvs_ros/blob/eb40fb317b3dc1b6ee82127b0cb49a8dfd1d3fe5/dvs_renderer/src/renderer.cpp#L20https://github.com/uzh-rpg/rpg_davis_simulator/blob/50e84063fffb9de609091df2f77b2ad52c3008fa/src/dvs_simulator_py/dvs_simulator.py#L176