uzh-rpg / rpg_dvs_ros

ROS packages for DVS
MIT License
300 stars 155 forks source link

Fixed dvs_calibration code not compiling on Ubuntu 20.04 / ROS Noetic #111

Closed vbrebion closed 3 years ago

vbrebion commented 4 years ago

ROS Noetic is bundled with OpenCV 4, meaning that some old C compatible constants (such as CV_CALIB_FIX_INTRINSIC) are not available anymore. This was leading the dvs_calibration package not to compile on Ubuntu 20.04 with ROS Noetic.

In order to fix the problem, these constants were therefore replaced by their C++ equivalent, which were also part of OpenCV 3. An other modification also had to be done, to compile a part of the code that was restricted to OpenCV 2 and OpenCV 3.

The corrected code was compiled on ROS Kinetic (Ubuntu 16.04), ROS Melodic (Ubuntu 18.04) and ROS Noetic (Ubuntu 20.04) without any issue.

llongi commented 3 years ago

Thank you for your contribution!