search

uzh-rpg / rpg_dvs_ros

ROS packages for DVS
MIT License
300 stars 155 forks source link

Fixed CirclesGridFinderParameters compile error for dvs_calibration #72

Closed luca-della-vedova closed 6 years ago

luca-della-vedova commented 6 years ago

The CirclesGridFinderParameters structure is already defined in OpenCV and redefinition in the header file causes a compile error.

Fixes #61 as well as cleaning up the code (removal of using namespace cv, which created ambiguity in the previous case).

guillermogb commented 6 years ago

Hi Luca, Can you check if this earlier fix, that is now merged in the master branch, solves your issue? https://github.com/uzh-rpg/rpg_dvs_ros/pull/69 Thanks.

luca-della-vedova commented 6 years ago

Hi Guillermo,

It seems the changes where mostly overlapping, I think this PR is not necessary anymore. Thanks! /Luca