SBUS Bridge - Githubissues

uzh-rpg / rpg_quadrotor_control

Quadrotor control framework developed by the Robotics and Perception Group

Other

595 stars 190 forks source link

SBUS Bridge #1

Closed mfaessle closed 6 years ago

mfaessle commented 6 years ago

This is a first implementation of a new sbus bridge. It still needs to be tested for all the functionality, especially whether varying rates of commands are no problem for the flight controller (from reading on the topic it should not be).

I messed up in that I pushed a few things after creating the repo without properly including it in the pull request here. But this package requires a full review (not just changes) anyways.

mfaessle commented 6 years ago

@tcies What about thread safety of flags that we set to let a thread know it should stop? Please have a critical look at those things in general ;)

tcies commented 6 years ago

Then see #2

mfaessle commented 6 years ago

TODO after merging #3 :

[x] Add example launch file
[x] Add parameter files for FC
[x] Add dependencies.yaml

mfaessle commented 6 years ago

Working and tested to a point where it is ready to be deployed. @tcies if you approve this, I will merge it into master...