search

uzh / marugoto

Marugoto: eLearning Framework for Story Telling
GNU General Public License v2.0
8 stars 6 forks source link

Email inbox - on left side show only mailForm and subject, remove mail body part #12

Closed christian-bernet closed 5 years ago

christian-bernet commented 5 years ago

done

martindusinberre commented 5 years ago

This is now closed (at least until I can see the new version) but we are having problems closing it...

christian-bernet commented 5 years ago

ok. I can close it. I have written to Pim, so that he can change the rights.

interrogator commented 5 years ago

Can we comment the commit / PR before closing? Sorry, it's just I'd like to learn more about the codebase, and so it's really useful if I can see where changes need to be made for various parts...

christian-bernet commented 5 years ago

what do you mean with comment the commit? The comment of the commit is for that change: "Remove body from mail list items"

interrogator commented 5 years ago

I mean, like if closing an issue, the code should now be in a branch, or in master. The commit that added the code should have a hash, which can be linked here so we can quickly see which commit solved the issue.

For example, I just paste the last commit on master here: 3d5559d, and github links it all automatically. This way, it's easy to get from an issue to its actual fix in the code.

interrogator commented 5 years ago

Definitely it's helpful that the commit message references the issue, but doing this as well makes it much more structured, and only takes a second.

christian-bernet commented 5 years ago

for frontend changes this won't work. it is commit ae0aae6 on dev branch in frontend.... But for backend changes we can do that.

interrogator commented 5 years ago

@christian-bernet, try:

uzh/marugoto-frontend@ae0aae6: uzh/marugoto-frontend@ae0aae6

christian-bernet commented 5 years ago

thanks