search

uzh / marugoto

Marugoto: eLearning Framework for Story Telling
GNU General Public License v2.0
8 stars 6 forks source link

Finish content for download pdf #38

Closed christian-bernet closed 5 years ago

christian-bernet commented 5 years ago

The content of the notebook pdf is not finished. we need to talk about how should the content should looks like. Estimate 8 hours

christian-bernet commented 5 years ago

change it like we want to have the focus on…

Add meta data (Person Date etc.) and Textstyling like the notebook

Finish each component so that it looks like in the notebook as the focus of the pdf rest like the on for the notebook

Fix also this broken unittests.

martindusinberre commented 5 years ago

This is the same as #23 so I closed #23.

christian-bernet commented 5 years ago

I created a new bug for the pdf on the test system. It's https://github.com/uzh/marugoto/issues/52.

christian-bernet commented 5 years ago

so this issue is finally only about change the content of the pdf

content of pdf should be:

christian-bernet commented 5 years ago

As discussed here are the first rough drafts of the PDF of a notebook.

One example of Plantation Lives without appendix: marugoto-notebook.pdf

One example of Demo Topic with new appendix: notebook-nemanja tišma.pdf

@martindusinberre Should we continue with this approach? So we will finalize that. Thanks for your feedback.

nemtish commented 5 years ago

Appendix added with commit: https://github.com/uzh/marugoto/commit/807d96d977cbd2a92aecba950a8ebc70ae92a9f9

martindusinberre commented 5 years ago

The comment from Ramun was how it would actually look with a lot of inputted data. If I were to do a proper play through, then would you able to see my inputs and turn them into a notebook PDF? If so, I can do that on Wednesday so that you have a lot of dummy text. As for my comments: it looks fine and please continue. Just a few issues:

  1. If I remember right, we said that we would keep single images (e.g. photo primary sources) together with the correct inputted page of the notebook, but any images with multiple jpg pages would be in the appendix: is that still the idea? Or would it be easier/quicker for you all if all imageComponents went into the appendix? Just tell me what you have in mind.
  2. I imagine that the fonts for the page titles/entries will be in a better font in the final PDF?
  3. Also, is it possible to add a header or a footer with page number and also the player's first and last name, so that the teacher can download multiple PDFs but be sure to whom they belong? But in general: it's looking good! Many thanks and please keep going. Let me/us know how you progress, and if you want me to look at other drafts.
christian-bernet commented 5 years ago

Thanks for your feedback. To your points:

  1. We show only the first image in the notebook. And in the appendix we will show only the images where there is "zoomable" set to true. OK for you?
  2. Yes, there is a problem at the moment with the fonts. so yes.
  3. Yes, we can add a header with TopicName - player name and page number
martindusinberre commented 5 years ago

Great. So 1.: in the appendix are images with "zoom" and also with multiple jpgs, with each jpg file appearing as a separate image in the appendix, right?

  1. Thanks. Is it also possible for you to set the name of the downloaded PDF file to include the player firstName+lastName?
christian-bernet commented 5 years ago

for 1: yes, exactly. 3: I think I would not waste time for it. Because it is always your name..... but we can do it, if you want.

martindusinberre commented 5 years ago

3: good, don't waste time on it! As long as the player name is visible on each notebook page, in that case. Thanks to you all.

nemtish commented 5 years ago

Drafts v1: marugoto-notebook.pdf

v2: Nemanja Ti_ma (3).pdf

nemtish commented 5 years ago

Filename is also changed to match name of the player

martindusinberre commented 5 years ago

@christian-bernet The notebook is looking really great. My personal preference is for a white background, not grey, as I think it looks cleaner. Can you just show an example in the appendix of a multi-jpg imageComponent, so that we can see what a 4 or 5 page document would look like in the notebook?

christian-bernet commented 5 years ago

Christian Bernet.pdf

@nemtish

@martindusinberre thanks for your feedback. Give us some time to finish it.... And then I can give you the wished example.

nemtish commented 5 years ago

Draft v3: Nemanja Ti_ma.pdf

christian-bernet commented 5 years ago

@martindusinberre I think in the draft v3: it shows what you want to see. And now the PDF download does also work at the test system. so you can download it at yourself. :-)

martindusinberre commented 5 years ago

Looks wonderful. Will try it with a full play-through on Friday/weekend and see how it copes with lots of material. Thanks to both of you, Martin

christian-bernet commented 5 years ago

@martindusinberre Can you have a look at this now and give us some feedback until Monday morning. It should works now on the test system. We will do the last changes here on Monday. We will also do some style changes on Monday that it looks better again.

martindusinberre commented 5 years ago

This is almost there. But one problem. Here is a screenshot of my very long notebook entry (to test #25 )

Screen Shot 2019-09-19 at 10 11 32
martindusinberre commented 5 years ago

And here is the relevant page in the notebook: MD_Notebook_p2_19Sept19.pdf

martindusinberre commented 5 years ago

You can see that the right-hand side margins for the notebook entry aren't correctly set in the PDF. You can also see that where there should be a page break in the notebook (because the entry is very long), the text just goes down to the end of the page and over the footer--and then runs out. Is there anything that can be done about this?

martindusinberre commented 5 years ago

@Helena-LiT @lfeine Can you also please check the PDF functionality for the notebook and give Christian any feedback before Monday? Thanks, Martin

christian-bernet commented 5 years ago

thanks. Yes, we can fix that at Monday.

martindusinberre commented 5 years ago

As mentioned, I'm going to close this issue now as it's basically done. Minor adjustments to the Notebook download PDF will be ticketed as new issues (e.g. the margins one is now #60)