search

uzh / marugoto

Marugoto: eLearning Framework for Story Telling
GNU General Public License v2.0
8 stars 6 forks source link

Fix supervise class screen #55

Closed christian-bernet closed 5 years ago

christian-bernet commented 5 years ago

Date selector If you change the date in frontend backend is not updated correctly. Please fix frontend component. image

christian-bernet commented 5 years ago

Create Class does not work If I fill out everything create button never gets enabled

christian-bernet commented 5 years ago

Finally: test all download links if they work

zlaxi commented 5 years ago

https://github.com/uzh/marugoto-frontend/commit/22cfcce8d27949b7eb61af15ab9a690f5b174e98

christian-bernet commented 5 years ago

Selected date in date picker is no stored in backend. If you set a date and come back afterwards to the same class nothing is saved and also the stored dates are not shown.

zlaxi commented 5 years ago

https://github.com/uzh/marugoto-frontend/commit/d7d8761603d48432fc2cd13bf69e65a0d17ad2ce

christian-bernet commented 5 years ago

ok. that works.

martindusinberre commented 5 years ago

@Helena-LiT This is an important one. Could you please check it carefully and close if you're happy? Thanks.

yaslena commented 5 years ago

All these features seem to work correctly: the date picker, editing class name and description; the link works; downloading the student notebook works (also when the game is unfinished). The only thing that startled me is that the students are not directed to any particular topic but are allowed to choose to play whatever they want. This seems a bit unusual for a class setting. However, the teacher can instruct the students to pick a particular storyline, so no big deal. If you try to use the link you generated as a teacher to play the game (with the same account) you get a warning that you can's supervise and play at the same time. Which is how it is supposed to be. All fine as far as I can tell.