search

uzh / marugoto

Marugoto: eLearning Framework for Story Telling
GNU General Public License v2.0
8 stars 6 forks source link

Money calculator mistake #9

Closed martindusinberre closed 5 years ago

martindusinberre commented 5 years ago

(again, from July 22:) I was just playing 2.4.3.1.1.5, where I had 301EUR. When I transitioned into 2.4.3.2, the game should have reduced my 301 EUR by 25 EUR (-25.0). But now I'm on 2.4.3.2, my money amount is simply shown as -25 EUR. So the calculator isn't quite working as planned.

christian-bernet commented 5 years ago

I tried it now on the test-system and it worked correctly.

martindusinberre commented 5 years ago

Long story short: there was a mistake in the "money" line in 2.4.1.3.1.4 and 2.4.3.1.1.4. (It was not marked as null). I've corrected this. @interrogator this is the kind of thing that it would be useful if maruval could check for (see commit 97b6966d8c for the problem and my solution). But it still doesn't solve the problem: in the transition from 2.4.3.1.1.5 to 2.4.3.2, which should reduce the player's overall money by 25 EUR, the game is not remembering the previous total, so that the money displayed on 2.4.3.2 is -25EUR (as if the money counter has started all over again). Is this a bug?