search

v-kiniv / rws

WebSocket gateway for ROS2 topics and services
Apache License 2.0
8 stars 4 forks source link

Service calls rcl_interfaces #4

Closed martinfri closed 1 year ago

martinfri commented 1 year ago

Hi @v-kiniv Cool library! Im trying it out a bit, pub sub works great and some service calls. But i get a silent crash when i try to call a service with the following interface

/foo/list_parameters
rcl_interfaces/srv/ListParameters

The same goes for other services of rcl_interface types. The line that seems failing is:

rmw_deserialize(sm, req_ts_hdl_, buf.get());

Any ideas what might cause this issue? Do all nodes that i spawn run rmw_fastrtps_dynamic_cpp?

v-kiniv commented 1 year ago

@martinfri Hi, please check #5 and let me know if it fixes the issue

martinfri commented 1 year ago

@v-kiniv Yes that solves the issue, thanks!

I have made some local improvments/changes as well is it ok to create pull requests to the repo?

v-kiniv commented 1 year ago

@martinfri Great, then I think we can merge #5 and close this issue. Sure, PR's are welcome.