search

v-ko / real-time-tab-sync

A Chrome extension to automatically synchronize your tabs across devices and sessions.
GNU General Public License v2.0
91 stars 10 forks source link

Tab groups and pinned tabs syncing #15

Open f0s3 opened 2 years ago

f0s3 commented 2 years ago

I wish there was an ability to sync the isPinned status of the tab so when you restore them on another device, they get restored as pinned. Same thing goes for the tab groups. I want the tab groups to be synced as well. I will try to find the time looking into the code and maybe developing this feature myself.

f0s3 commented 2 years ago

@v-ko I plan on creating a pull request, but I think I might need a bit of your help. I want to refactor this code as I think it could be simplified by a lot and I need the creator like you to know what is going to happen. What do you think?

f0s3 commented 2 years ago

As to the tab groups, I think I can do this, but there are tab group ids instead of the names, so I will need to figure out where the names are stored (somehow getting the name by groupId).

I have created a pull request, but not sure how to test if it works or not.

@v-ko Let me know if you can help me with that.

f0s3 commented 2 years ago

I found a way to test it. It now restores the tabs and pins the ones, that were pinned on other device.

I found a couple of issues and will resolve them as well as adding tab groups functionality later when I have time.

For now, no help needed. I also will look into the performance and how the app can become a bit faster or if it's possible at all.

v-ko commented 2 years ago

Thanks for the contributions, @f0s3 , I'll be traveling in the next couple of weeks, but I might find time to test and release the changes in the mean time.

f0s3 commented 2 years ago

I did some major improvements in the performance by changing the compression/decompression algorithm and reducing the save/restore delay (you can see the details here).

I think it's too early to release anything. I will try adding tab groups support and will refactor the code a bit more. Maybe some more performance improvements as well.

But I think it would be great if you could test it. The goal of my contribution is to have something that will work similarly to the VS Code Server, i.e. it will work almost instantly and without any issues with duplicated tabs, etc.

f0s3 commented 2 years ago

Is there a possibility we can meet in google meet, discord or anything like that?

Currently I have issues with syncing (it doesn't see my other device for some reason). I thought what if we expose the device id to the user on popup and add a field for connection to the device id (source)? That would be neat I think.

What do you think about it?

image

v-ko commented 2 years ago

I'm ok with a call, just dropped you a mail. I'm not familiar with VSCode server, but after a quick search - I'm guessing it's a service on the worker machine, which remote client VScode instances connect to. Do you have something like that in mind? Or again using the Chrome sync API, but with a targeting mechanism to select which machine to sync to specifically? (or something else entirely?)