v-ngu / backstage-plugin-bulletin-board

Bulletin Board is a Backstage plugin that allows you to share interesting ideas, news and links with your teammates.
MIT License
17 stars 8 forks source link

bulletin plugin not supporting backstage version 1.20.2 #30

Closed prasoon-pxc closed 7 months ago

prasoon-pxc commented 10 months ago

Earlier, i had backstage 1.17.5 installed, also I was using the newest version of bulletin plugin but after upgrading backstage to 1.20.2 version, it is giving error on docker image build, With new backstage version we have required node version greater than 16.

Error:

yarn run v1.22.19
$ tsc
packages/backend/src/plugins/bulletin-board.ts:11:5 - error TS2322: Type 'import("/home/il58d0/smb/backstage-conf-repo/backstage-conf-repo-original/node_modules/@backstage/backend-plugin-api/dist/index").DatabaseService' is not assignable to type 'import("/home/il58d0/smb/backstage-conf-repo/backstage-conf-repo-original/node_modules/backstage-plugin-bulletin-board-backend/node_modules/@backstage/backend-plugin-api/dist/index").DatabaseService'.
  The types returned by 'getClient()' are incompatible between these types.
    Type 'Promise<import("/home/il58d0/smb/backstage-conf-repo/backstage-conf-repo-original/node_modules/knex/types/index").Knex<any, any[]>>' is not assignable to type 'Promise<import("/home/il58d0/smb/backstage-conf-repo/backstage-conf-repo-original/node_modules/backstage-plugin-bulletin-board-backend/node_modules/@backstage/backend-plugin-api/node_modules/knex/types/index").Knex<any, any[]>>'.
      Type 'import("/home/il58d0/smb/backstage-conf-repo/backstage-conf-repo-original/node_modules/knex/types/index").Knex<any, any[]>' is not assignable to type 'import("/home/il58d0/smb/backstage-conf-repo/backstage-conf-repo-original/node_modules/backstage-plugin-bulletin-board-backend/node_modules/@backstage/backend-plugin-api/node_modules/knex/types/index").Knex<any, any[]>'.
        The types of 'raw(...).transacting' are incompatible between these types.
          Type '(trx: import("/home/il58d0/smb/backstage-conf-repo/backstage-conf-repo-original/node_modules/knex/types/index").Knex.Transaction<any, any[]>) => import("/home/il58d0/smb/backstage-conf-repo/backstage-conf-repo-original/node_modules/knex/types/index").Knex.Raw<any>' is not assignable to type '(trx: import("/home/il58d0/smb/backstage-conf-repo/backstage-conf-repo-original/node_modules/backstage-plugin-bulletin-board-backend/node_modules/@backstage/backend-plugin-api/node_modules/knex/types/index").Knex.Transaction<any, any[]>) => import("/home/il58d0/smb/backstage-conf-repo/backstage-conf-repo-original/no...'.
            Types of parameters 'trx' and 'trx' are incompatible.
              Type 'Transaction<any, any[]>' is missing the following properties from type 'Transaction<any, any[]>': comment, except, havingNull, havingNotNull, updateFrom

11     database: env.database,
       ~~~~~~~~

  node_modules/backstage-plugin-bulletin-board-backend/dist/index.d.ts:8:5
    8     database: PluginDatabaseManager;
          ~~~~~~~~
    The expected type comes from property 'database' which is declared here on type 'RouterOptions'

Found 1 error in packages/backend/src/plugins/bulletin-board.ts:11
moley commented 9 months ago

Hello together, any update on this? I'd like to as well use this plugin but am blocked by this. Is this plugin still living or deprecated?

rmnicholson0612 commented 8 months ago

Yeah this is annoying. I need features in 1.20 and there doesn't seem to be maintainers keeping this plugin up to date...

v-ngu commented 8 months ago

It is still alive, but have been caught up on other things unfortunately. Anyone would like to contribute?