v-rising / ModernCamera

MIT License
48 stars 3 forks source link

Action mode toggle using middle mouse button in GUI #16

Open WesCook opened 1 year ago

WesCook commented 1 year ago

First of all, I'd like to see that this mod is wonderful, and I would love to see its functionality adopted into the official game.

This issue/request is a little niche, and I'll understand if you don't wish to support it.

I like to use middle mouse button (MMB) as my toggle for the Action Mode. I find it very easy to switch modes based on context, and this flows well with V Rising's gameplay.

The problem is that MMB is also used for splitting inventory stacks. Intuitively, that behaviour should take precedence in inventories, and action mode toggling should take precedence when out of inventories. But when splitting a stack, it will also toggle action mode.

The simplest fix would be to check if a GUI is open before running the function. However, it may be preferred to allow action mode toggling from within a UI. In that case, checking both that a GUI is open and that the keybind is a mouse button would be required.

Let me know what you think. Again, I know this is rather niche, and that you're currently working on the larger Gloomrot update, so no hurt feelings either way.

Cheers!