v-rising / ModernCamera

MIT License
48 stars 3 forks source link

1.0 Hotfix #5 #24

Open DeanMaxwell opened 4 months ago

DeanMaxwell commented 4 months ago

Modern Camera functionality has been *affected by the hotfix on 5/29/2024. UI options menu is inaccessible, but still configurable in the options.jsonin /BepInEx/config/silkworm. However, the camera modifications appear to be somewhat functional allowing the player to still utilize alternative camera perspectives.

For controller users, something similar to the older functionality of this mod's Action Mode can be achieved by: utilize Steam Input to modify the Left Trigger, turn on the 'Toggle' functionality.

While this is a solid improvement for controller users, going forward, where development could improve controller support is with the aiming of Weapon Skills and Spells that require placement (for example, Bow/Crossbow or AOE spells), as these do not function well with current code (always firing to the North orientation).

W4YFIND3R commented 4 months ago

@DeanMaxwell How are you configuring options.json? Unfortunately I don't have a good example as mine is just "{}"

I tried to add:

{
    "IsActionMode": true
}

But I get a [Warning: Silkworm] Error reading options.json:

[Info   :   BepInEx] Loading [Silkworm 2.0.0]
[Warning:  Silkworm] Error reading options.json
[Info   :  Silkworm] Plugin iZastic.Silkworm v2.0.0 is loaded!
[Info   :   BepInEx] Loading [ModernCamera 1.5.6]
[Info   :Il2CppInterop] Registered mono type ModernCamera.ModernCamera in il2cpp domain
[Info   :ModernCamera] Plugin VRising.ModernCamera v1.5.6 is loaded!

If I just use {} or use "null" instead of "true" I get no error.

I also tried

{
    "Keybindings": {
        "moderncamera.actionmode": "l"
    }
}

Which also causes no error, but the key doesn't seem to work

If you're setting IsActionMode manually, how are you doing it? Thanks

DeanMaxwell commented 4 months ago

@W4YFIND3R

So I believe ActionMode is still busted since the v1.0 release. What I was sharing was a bit of a workaround for controller users via Steam Input (toggle on Left Trigger (for controllers) or Right Click (for M+KB).

Here is a working .json format:

{
  "Modern Camera": {
    "Name": "Modern Camera",
    "Toggles": {
      "moderncamera.enabled": true,
      "moderncamera.firstperson": true,
      "moderncamera.defaultbuildmode": true,
      "moderncamera.alwaysshowcrosshair": false,
      "moderncamera.actionmodecrosshair": true,
      "moderncamera.lockzoom": false,
      "moderncamera.lockpitch": false,
      "moderncamera.overtheshoulder": false
    },
    "Sliders": {
      "moderncamera.fieldofview": 60,
      "moderncamera.aimoffsetx": 10,
      "moderncamera.aimoffsety": 0,
      "moderncamera.minzoom": 1,
      "moderncamera.maxzoom": 6,
      "moderncamera.lockzoomdistance": 15,
      "moderncamera.minpitch": 9,
      "moderncamera.maxpitch": 90,
      "moderncamera.lockpitchangle": 60,
      "moderncamera.overtheshoulderx": 1,
      "moderncamera.overtheshouldery": 1
    },
    "Dropdowns": {
      "moderncamera.aimmode": "Default"
    }
  }
}

Note: You will likely want to adjust zoom distance, etc. to your own tastes.

dimentox commented 4 months ago

I am redoing the config removing from ui and just getting action mode working

On Sat, Jun 1, 2024, 11:32 AM DeanMaxwell @.***> wrote:

@W4YFIND3R https://github.com/W4YFIND3R

So I believe ActionMode is still busted since the v1.0 release. What I was sharing was a bit of a workaround for controller users via Steam Input (toggle on Left Trigger (for controllers) or Right Click (for M+KB).

Here is my .json format that was generated by the mod when the UI was working before the hotfix:

{ "Modern Camera": { "Name": "Modern Camera", "Toggles": { "moderncamera.enabled": true, "moderncamera.firstperson": true, "moderncamera.defaultbuildmode": true, "moderncamera.alwaysshowcrosshair": false, "moderncamera.actionmodecrosshair": true, "moderncamera.lockzoom": false, "moderncamera.lockpitch": false, "moderncamera.overtheshoulder": false }, "Sliders": { "moderncamera.fieldofview": 60, "moderncamera.aimoffsetx": 10, "moderncamera.aimoffsety": 0, "moderncamera.minzoom": 1, "moderncamera.maxzoom": 6, "moderncamera.lockzoomdistance": 15, "moderncamera.minpitch": 9, "moderncamera.maxpitch": 90, "moderncamera.lockpitchangle": 60, "moderncamera.overtheshoulderx": 1, "moderncamera.overtheshouldery": 1 }, "Dropdowns": { "moderncamera.aimmode": "Default" } } }

Note: You will likely want to adjust zoom distance, etc. to your own tastes.

— Reply to this email directly, view it on GitHub https://github.com/v-rising/ModernCamera/issues/24#issuecomment-2143506937, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGRJPDWHWTCFICK4VXU3GTZFHZTPAVCNFSM6AAAAABIPA652SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBTGUYDMOJTG4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

W4YFIND3R commented 4 months ago

Thanks Dimentox and DeanMaxwell, It's really appreciated!

KiriGo commented 4 months ago

I was able, with the help of betas, to go back to the old version of V-Rising. And ran a working version of the mod. Got all the configuration files, as well as the keybind file... don't know if it will work.... (for the test I assigned the keys ~, -, + to the actions).

options.json

{
  "Modern Camera": {
    "Name": "Modern Camera",
    "Toggles": {
      "moderncamera.enabled": true,
      "moderncamera.firstperson": true,
      "moderncamera.defaultbuildmode": true,
      "moderncamera.alwaysshowcrosshair": false,
      "moderncamera.actionmodecrosshair": false,
      "moderncamera.lockzoom": false,
      "moderncamera.lockpitch": false,
      "moderncamera.overtheshoulder": false
    },
    "Sliders": {
      "moderncamera.fieldofview": 60,
      "moderncamera.aimoffsetx": 0,
      "moderncamera.aimoffsety": 0,
      "moderncamera.minzoom": 2,
      "moderncamera.maxzoom": 18,
      "moderncamera.lockzoomdistance": 15,
      "moderncamera.minpitch": 9,
      "moderncamera.maxpitch": 90,
      "moderncamera.lockpitchangle": 60,
      "moderncamera.overtheshoulderx": 1,
      "moderncamera.overtheshouldery": 1
    },
    "Dropdowns": {
      "moderncamera.aimmode": "Default"
    }
  }
}

keybindings.json

{
  "Modern Camera": {
    "Name": "Modern Camera",
    "Keybindings": {
      "moderncamera.enabled": {
        "Id": "moderncamera.enabled",
        "Name": "Enabled",
        "Primary": 96,
        "Secondary": 0
      },
      "moderncamera.actionmode": {
        "Id": "moderncamera.actionmode",
        "Name": "Action Mode",
        "Primary": 45,
        "Secondary": 0
      },
      "moderncamera.hideui": {
        "Id": "moderncamera.hideui",
        "Name": "Hide UI",
        "Primary": 61,
        "Secondary": 0
      }
    }
  }
}
dimentox commented 4 months ago

I am just about done with the completed version just finishing keybindings

xinping1989 commented 4 months ago

how did you guys managed to make it work via json? just paste that config?

dimentox commented 4 months ago

Technically it should not work as the lib was not quite fixed

On Mon, Jun 3, 2024 at 4:04 AM xinping1989 @.***> wrote:

how did you guys managed to make it work via json? just paste that config?

— Reply to this email directly, view it on GitHub https://github.com/v-rising/ModernCamera/issues/24#issuecomment-2144672470, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGRJPC2OPBG2HOBMA6TBWLZFQWTDAVCNFSM6AAAAABIPA652SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBUGY3TENBXGA . You are receiving this because you commented.Message ID: @.***>

W4YFIND3R commented 4 months ago

how did you guys managed to make it work via json? just paste that config?

We didn't, sorry for any confusion. I tried using KiriGo's configs, but keybindings didn't toggle anything etc.

Only free camera seems to work at this current time until dimentox is finished their update.

xinping1989 commented 4 months ago

We got another hotfix #6 this time the devs at stunlock made changes again to the options menu

KiriGo commented 3 months ago

Я почти закончил работу над завершенной версией, просто заканчиваю привязку клавиш.

Any news?

j3crow commented 3 months ago

Just thought I'd check-in to see how this is going. I flat-out don't play V Rising without this mod

kill3rvill3 commented 3 months ago

Hey So is it still the case that we are waiting on the modder to update the libraries ? if so is there any update on progress or timelines ? If there is anything the community can help with I am sure we would

AndrewSav commented 3 months ago

@kill3rvill3 figuring out how key bindings can be modded after the changes introduced in the last patch would be a start

j3crow commented 3 months ago

Just thought I'd check to see if there is any news. It goes without saying, that the mods doing the work on this are doing so voluntarily, so not complaining at all. Just really miss this mod. I hope it comes back

DeanMaxwell commented 3 months ago

I'll reiterate. This mod works very well still. You just need to be a little creative with Steam Input binding for your mouse or controller. Action mode can be replicated very easily.

kill3rvill3 commented 3 months ago

@DeanMaxwell Thanks for this I am using the mod without binds at the moment. Is there a link which outlines how to get creative with steam input bindings to or can you tell me where those options.json and bindings.json files are placed to achieve your workaround ?