search

v-trof / Ripple.js

Proper Material Design ripple effect for the web, that wouldn't interfere your elements' DOM.
17 stars 0 forks source link

Single pixel movement fix #15

Closed itayganor closed 7 years ago

itayganor commented 7 years ago

When holding down, the ripple may shift a pixel to the side. As described here: https://stackoverflow.com/a/15623914/6340965

v-trof commented 7 years ago

Can you please describe how this issue might be related to Ripple.js? It seems impossible for 2 reasons

  1. Ripple only uses scale, there is no other transform, so it does not rotate anyway.
  2. That issue is 4 years old and it is already fixed in browser itself.
itayganor commented 7 years ago

Sure! Click and hold the "LOGIN" tab at the top of the page here. You can see the ripple is moving one pixel right when the transform is done. I'm using the latest version of Windows and Chrome.

Video example: YouTube