search

v-zhuravlev / zbx-smartctl

Templates and scripts for monitoring disks health with Zabbix and smartmontools
https://share.zabbix.com/storage-devices/smartmontools/smart-monitoring-with-smartmontools-lld
GNU General Public License v3.0
245 stars 127 forks source link

debhelper install file is incorrect #21

Closed alllel closed 7 years ago

alllel commented 7 years ago
  1. Syntax of install file is: source_file destination_DIR, not dest_FILE
  2. On Ubuntu, default directory for zabbix_agent configs is /etc/zabbix/zabbix_agentd.conf.d not just /etc/zabbix/zabbix_agentd.d

Proposed file zabbix-agent-extra-smartctl.install :

sudoers_zabbix_smartctl etc/sudoers.d discovery-scripts/nix/smartctl-disks-discovery.pl usr/lib/zabbix/scripts zabbix_smartctl.conf etc/zabbix/zabbix_agentd.conf.d

v-zhuravlev commented 7 years ago

@vazhnov , could you please comment on this? Thank you

alllel commented 7 years ago

One more thing: script should be done executable somehow. Now it is packaged into deb as non-executable, so discovery does not work.

alllel commented 7 years ago

And one more thing: package should have postinst/postrm files to reload zabbix-agent on installation/deinstallation. Something like that: debian/zabbix-agent-extra-smartctl.postinst

!/bin/sh

set -e

case $1 in configure) invoke-rc.d zabbix-agent restart esac

DEBHELPER