search

v0-alpha / src-mq

Lucid breakpoints for JavaScript
MIT License
1 stars 0 forks source link

Add documentation to readme #18

Closed sndrs closed 5 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #18 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #18   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          32     32           
  Branches        1      1           
=====================================
  Hits           32     32
sndrs commented 5 years ago

I've updated this along the lines of what we've been discussing offline. Please feel free to pick holes!

Shall we use this PR to maybe kick the API about? once we're happy with this readme we update the tests to cover it and then the code?

sndrs commented 5 years ago

@SiAdcock i think is up to date with what we've discovered/decided.

if it all worked like this, you think it's v1able?

SiAdcock commented 5 years ago

I dunno, em seems more useful than px as an output unit. I mean the assumption that 1em = 16px. Can the consumer override the body font size and break the assumption?