search

v0l / snort

Feature packed nostr web UI, Mirror of https://git.v0l.io/Kieran/snort
https://snort.social
MIT License
321 stars 125 forks source link

Login form needs to protect privacy of the secret key #495

Closed vivganes closed 1 year ago

vivganes commented 1 year ago

Is your feature request related to a problem? Please describe. The current login form uses an ordinary unmasked text field to input the key. This doesn't protect the privacy of the user as attacker could take a picture of the screen and use it to login later.

Describe the solution you'd like Use a password input field instead, optionally allowing the user to reveal the text input on demand.

Describe alternatives you've considered Nothing.

Additional context Additional advantage is that password managers like bitwarden can be used to auto-fill without much hassle.

Johnny112F commented 1 year ago

I'm happy to work on this issue.

vivganes commented 1 year ago

I'm happy to work on this issue.

I submitted PR #499 that aims to fix this issue. It is in review now.

Happy to collaborate with you on that if you want to.

Johnny112F commented 1 year ago

Collaborating would be great. It looks like your fix resolved the issue well. I coded a quick solution but I think yours has passed.

vivganes commented 1 year ago

@Johnny112F I was planning on starting #502 today. If you want to take it up, I will work on something else. If you need any help, I can also help you in of any issue of your choice (including #502)

Johnny112F commented 1 year ago

@vivganes Thank you for asking. I may pass on that task for the time being to some time constraints, but would be interested in seeing the results.