v10networkscom / saltychat-docs

Documentation for Salty Chat (TeamSpeak 3 based Voice Plugin)
https://gaming.v10networks.com
15 stars 22 forks source link

Add FiveM Lua resource #60

Closed FirstWiseman closed 3 months ago

FirstWiseman commented 3 months ago

Added Saltychat Fivem Lua to the Available Resources

BlackFlash5 commented 3 months ago

Great to see someone converting the resource for the Lua lovers out there and try to keep it compatible with the C# version! I skipped a bit through the repo and found a few little things that need attention:

FirstWiseman commented 3 months ago

Great to hear that. Thanks for the report about the little things that i have, appreciate it.

I have made the changes now, except for the OneSync thing that you have mentioned, because i dont really understand exactly what you want or what needs to be changed.

BlackFlash5 commented 3 months ago

You should only accept on when checking the onesync-var, since OneSync infinity is required for state bags to function. legacy and off can't be accepted, the script wont function as intended and a console message should be displayed.

The link for default keybinds (Setup Steps > 4.) is still linking to our repo. For proper use of notifications you can look into the C# implementation, your new notification for voice range change probably doesn't work.

FirstWiseman commented 3 months ago

I have made these changes now. And the Notifications work perfectly fine this way. Here is a Screenshot image