v10networkscom / saltychat-fivem

FiveM implementation of Salty Chat (TeamSpeak 3 based Voice Plugin)
https://gaming.v10networks.com
GNU General Public License v3.0
70 stars 64 forks source link

salty****/***/bin/Release missing #104

Closed PC1up closed 2 years ago

PC1up commented 2 years ago

So I wanted to change some things for my server and tried to build them using the PowerShell script. Basically, everything worked except the following paths: saltychat\SaltyClient\bin\Release\SaltyClient.net.dll saltychat\SaltyClient\bin\Release\SaltyClient.net.pdb saltychat\SaltyServer\bin\Release\netstandard2.0\SaltyServer.net.dll saltychat\SaltyServer\bin\Release\netstandard2.0\SaltyServer.net.pdb saltyhud\SaltyClient\bin\Release\SaltyClient.net.dll saltyhud\SaltyClient\bin\Release\SaltyClient.net.pdb

I also tried to build the resources in VS but it didn't change anything PowerShell tells me, that there paths are not existing/cannot be found. These errors are in German but I'm gonna send them anyway image

xPiwel commented 2 years ago

Instead of building it through VS, try to download a release : https://github.com/v10networkscom/saltychat-fivem/releases

And what did you tried to edit exactly ?

PC1up commented 2 years ago

I wanted to add a thingy to the config to add the FiveM name to the teamspeak name. Smth like this: "[{id}] {name}"

BlackFlash5 commented 2 years ago

The PowerShell script doesn't build the solution since that's something the build action does. You need to build the solution with the release preset for the script to work. In the top of VS you should see a drop-down with Debug pre-selected, change it to Release, build the solution and the script should run without any issues.

This is currently expected behavior, since msbuild isn't in your PATH after installing VS. We could probably check it and let the script build the solution (with a fallback to e.g. C:\Program Files\Microsoft Visual Studio\2022\Professional\Msbuild\Current\Bin\MSBuild.exe). We'll categorize this as enhancement for now.

BlackFlash5 commented 2 years ago

The script is now building the solution instead of the GitHub action, see f473d8bf97886136183f59b784fd33dee54541b8.