Closed MypowerHD closed 4 years ago
Update NuiEvent.cs Change const propertys values to nameof(propertyname).
Update Util.cs remove unused usings add missing exception
Update VoiceManager.cs the "_voiceClients" field is sometimes used inside sync block and sometimes without synchronization Invert 'if' statements to reduce nesting use "string" instead of "String" if/retrun statements to inline with '?:' operator fix naming issues "metres" => "meters" / "funtion" => "function"
Update Radio.cs Invert 'if' statement to reduce nesting Lock "_members"
Update VoiceManager.cs lock "_radioChannels"
more updates
That's not how PRs work, you don't put multiple changes in one PR that are incoherent. You should also explain why you change things and why your way is better.
Changing stuff like Int32.TryParse()
to int.TryParse()
is just bad practice, because int
is keyword/alias for Int32
and used for easy type declaration.
For methods and and so on you use Int32
, because that is the struct/class where all the methods are.
Easyly we can use here the Propertynames because we use them instead. I always use "nameof" in such situations, because in the case of refactoring, the variable values are also adjusted automaticly.