v10networkscom / saltychat-fivem

FiveM implementation of Salty Chat (TeamSpeak 3 based Voice Plugin)
https://gaming.v10networks.com
GNU General Public License v3.0
71 stars 64 forks source link

Some Updates(locks, invert if statements, naming issues etc.) #15

Closed MypowerHD closed 4 years ago

MypowerHD commented 4 years ago

Easyly we can use here the Propertynames because we use them instead. I always use "nameof" in such situations, because in the case of refactoring, the variable values are also adjusted automaticly.

MypowerHD commented 4 years ago
MypowerHD commented 4 years ago

more updates

BlackFlash5 commented 4 years ago

That's not how PRs work, you don't put multiple changes in one PR that are incoherent. You should also explain why you change things and why your way is better.

Changing stuff like Int32.TryParse() to int.TryParse() is just bad practice, because int is keyword/alias for Int32 and used for easy type declaration. For methods and and so on you use Int32, because that is the struct/class where all the methods are.