v10networkscom / saltychat-fivem

FiveM implementation of Salty Chat (TeamSpeak 3 based Voice Plugin)
https://gaming.v10networks.com
GNU General Public License v3.0
70 stars 64 forks source link

Proposal: Configurable Keybinds #19

Closed leonkappes closed 3 years ago

leonkappes commented 3 years ago

The feature

One would be able to specify custom Keys for things like TalkPrimaryRadio, Megaphone, etc. This could be achieved in two ways:

  1. Set the Control Index in the fxmanifest(like Swisschannels etc)
  2. By using KeyMapping

Sidenote

I know that this project isn't oriented in the everything works out-of-the-box schema. And that's a good thing. But I think this would be a great feature.

Intention

I wanted to implement 1 of the 2 solutions but first I wanted to know if you would accept/merge/want this feature so I wouldn't waste my time making a Pull-Request and secondly I wanted your opinion on which solution to choose.

Thanks in advance

BlackFlash5 commented 3 years ago

Do the "new" key binds also support controllers, so you can use the keyboad and controller? If not, it's not worth it, since you'd be annoyed that you have to use the keyboad while driving with a controller. Another gotcha would be the keyboad layout, e.g. INPUT_ENTER_CHEAT_CODE works on every layout, while some keys wouldn't because they are region specific. I'd stick to the current method and just use in-game controls.

If you want to implement more config parameters, I'd also suggest introducing a json or xml config file which can be loaded through LoadResourceFile().

We pretty much accept every non-bs PR with good code quality.