v10networkscom / saltychat-fivem

FiveM implementation of Salty Chat (TeamSpeak 3 based Voice Plugin)
https://gaming.v10networks.com
GNU General Public License v3.0
71 stars 64 forks source link

signalDistortion in Phone Calls #3

Closed Doxylamin closed 4 years ago

Doxylamin commented 4 years ago

GetZoneScumminess returns a value between 0 - 5, where 5 is the best signal. With the current code, if both parties are in a 5/5 signal range, their call will have the worst quality, because the best signal of the plugin is specified as 0. This simple PR fixes this problem.

BlackFlash5 commented 4 years ago

That is actually false. The native GetZoneScumminess returns an index from 0 to 5 which indicates how bad the area is. 0 is a totally nice area like Vinewood and 5 is a bad area like Davis. So that native has nothing to with signal strength in particular, but R* is using this to display the signal bars on the iFruit phone (0 = full bars, 5 = one/none bars).

If you want to see it yourself, here you got a code snippet, that you can use (/zone in chat):

[Command("zone")]
private static void OnZoneCommand()
{
    Vector3 position = Game.PlayerPed.Position;

    string zoneName = World.GetZoneLocalizedName(position);
    int scumminess = API.GetZoneScumminess(API.GetZoneAtCoords(position.X, position.Y, position.Z));

    Debug.WriteLine($"Zone: {zoneName} | Scumminess: {scumminess}");
}