v10networkscom / saltychat-fivem

FiveM implementation of Salty Chat (TeamSpeak 3 based Voice Plugin)
https://gaming.v10networks.com
GNU General Public License v3.0
70 stars 64 forks source link

Radio doesn't work #31

Closed NylanderrDK closed 3 years ago

NylanderrDK commented 3 years ago

Hi.

We can't talk over the radio, but normal talk works. It's a clean install.

Did anybody else experienced this issue?

RaGeQuiT656 commented 3 years ago

same problem

leonkappes commented 3 years ago

The Radio doesn't do anything on its own. What's your code to put the people into the same Radio-Channel?

NylanderrDK commented 3 years ago

The Radio doesn't do anything on its own. What's your code to put the people into the same Radio-Channel?

When I take a look into the code, there is a command, that puts the people in the same radio channel - that's the one I use.

leonkappes commented 3 years ago

As you can see by this line these commands are just included in a Debug build and should generally not be used in production. Use the provided exports to set a user in a Channel

bastienbichonparadize commented 3 years ago

I Have the same Issue but don't know how to reproduce. Sometimes, the radio just stop working (when you are talking, it seems to be sent over Teamspeak but other players cannot hear).

When restarting saltychat the problem is fixed. (Sometimes we have to restart Saltychat multiple times).

We are experiencing this issue either with low amount of players or +100 players.

leonkappes commented 3 years ago

So first of all: For the future, if you have a problem of your own -> Open an own Issue. But have you tried changing these Teamspeak Server settings? If yes what did you try to fix these issues, do you run salty unmodified, which version, etc... Without more information, I can just tell you: it is your issue and salty, if setup well/correct, has no problems working

bastienbichonparadize commented 3 years ago

Not modified version. 2.1 (The one before the radio volume)

Here is the error in the console before radio breaks (voice and phone call still works after the error)

Error invoking callback for event playerDropped: System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.NullReferenceException: Object reference not set to an instance of an object.

at SaltyServer.RadioChannel.RemoveMember (SaltyServer.VoiceClient voiceClient) [0x001ec] in C:...\saltychat\SaltyServer\Radio.cs:85 at SaltyServer.VoiceManager.OnPlayerDisconnected (CitizenFX.Core.Player player, System.String reason) [0x00061] in C:...]\saltychat\SaltyServer\VoiceManager.cs:98 at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&) at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0006a] in :0

Exception_EndOfInnerExceptionStack

at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00083] in :0 at System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) [0x00000] in :0 at System.Delegate.DynamicInvokeImpl (System.Object[] args) [0x000e7] in :0 at System.MulticastDelegate.DynamicInvokeImpl (System.Object[] args) [0x00008] in :0 at System.Delegate.DynamicInvoke (System.Object[] args) [0x00000] in :0 at CitizenFX.Core.EventHandlerEntry.Invoke (System.String sourceString, System.Object[] args) [0x00064] in C:\gl\builds\4ff63adb\0\cfx\fivem\code\client\clrcore\EventHandlerDictionary.cs:89

BlackFlash5 commented 3 years ago

It most likely runs into an exception because the ped (Character) of a radio channel member is null.

channelMember.VoiceClient.Player.Character.Position

If that is the case, the issue is with FiveM OneSync, not the Salty Chat script.

There was some other guy who had a similar issue. If you don't care about solving the issue with FiveM and just want it to work, then you can use a workaround like this.

Btw this issue has absolutely nothing to do with the one @NylanderrDK has. Since he also isn't providing any useful information (exact steps, logs, mic clicks audible, etc), I'm just gonna close this.

bastienbichonparadize commented 3 years ago

Thank you for the reply. You're the best !

Kind regards

alfiansm27 commented 3 years ago

Hi.

We can't talk over the radio, but normal talk works. It's a clean install.

Did anybody else experienced this issue?

Do you have solution? i have same problem