[FIXED #50] Radio Speaker - Issue when player turns off the Speaker

[xPiwel]

Hello,

Using 2.2.0.

Found an issue where the radio speaker keeps sending members voice when the client turns off his speaker.

Details of my issue (repro) :

• Player A and Player B turns on their radio on frequency 66. (away from each other)
• Player C is not on any radio, but is close to Player A.
• Player A turns on his radio speaker >> Player C can hear Player B via Player A.
• If Player A turns off his radio speaker when no one is sending voice on radio > works perfectly.
• If Player A turns off his radio speaker while Player B is sending voice on frequency here are the issues :

  Player C can still hear Player B on speaker while sending voice on radio frequency to Player A. Player C can hear Player B even if he speaks normal (not on the radio instance).

Here is my client side : function Radio:Speaker() local getPlayerRadioSpeaker = exports.saltychat:GetRadioSpeaker() if not getPlayerRadioSpeaker then TriggerServerEvent("radio:setRadioSpeaker", true) else TriggerServerEvent("radio:setRadioSpeaker", false) end end

Here is my server side: RegisterServerEvent("radio:setRadioSpeaker") AddEventHandler("radio:setRadioSpeaker",function(getPlayerRadioSpeaker) exports.saltychat:SetPlayerRadioSpeaker(source, getPlayerRadioSpeaker) end)

Thanks !

[xPiwel]

Here is a screen of TeamSpeak,

[1] is Player C > [6] is Player A. They are close to eachother

[3] is Player B, 500m away from Player A and C but look : https://prnt.sc/zmrvhx

[BlackFlash5]

Since i don't have 2 other ppl to test with, can you test the above mentioned commit/branch?

[xPiwel]

Since i don't have 2 other ppl to test with, can you test the above mentioned commit/branch?

Will try tommorow. I'll post and close if resolved, else will provide issues.

Thanks for the fast answer!

[xPiwel]

Ok so, I've been testing the commit with Player A, B, C and a new one D. Made a lots of test trying to find an issue but everything seems fixed correctly !

We've tested every potential issue with the speaker function but everything is fine.

Issue fixed, thank you !

[xPiwel]

Hello @BlackFlash5 ,

I am reopening this issue cause we've got a new issue related since I've made the changes of your commit.

When a player joins a frequency, and leave it, he can still hear radios bips like if someone has sent voice on his frequency but he is not in any. I've provided you a video, you can see exactly what I am doing.

(Timecodes in the video are provided)

• Joining a frequency random. (0.02 secs)

• Talking into it a bit. (0.03s)

• Leaving it. (0.08s)

• Waiting a few seconds/minute and I can hear a radio sound even if I'm not on any frequency. (1mn04s)

• 67 players online when testing with the video. After making this video, I've had a loooooot of radios clics without hearing anyone or being on a frequency.

This did never happened before. Is it related ? Haven't made any changes on my radio script (only the changes for the speaker, that I've left above on the first comment).

Here is the video of the problem: https://youtu.be/xY1vysY_yV8

[BlackFlash5]

I also need an extensive log for that since i don't know what the plugin receives through a video.

[xPiwel]

I've made a clean debug, put the logs of salty chat to extensive.

The all TeamSpeak logs are me doing this :

• Connecting
• Joining a frequency
• Talking 3/4 times
• Disconnecting from frequency
• Waiting long minutes
• Getting 3 radios clics (bips sounds) without being on a frequency
• Disconnecting from everywhere to keep clean logs for you.

In this session, I haven't talked with anyone or got closer with anyone in game. You can find FiveM & TeamSpeak logs of the session below.

Logs : https://we.tl/t-2xOS4iNqgF

[BlackFlash5]

Should be fixed with 2fdc29f, can you try it out and confirm that it's working?

[xPiwel]

Should be fixed with 2fdc29f, can you try it out and confirm that it's working?

Pushed right away your commit. Built the solution, I'll try this out with my players for the next 24 hours and will tell you or close this if resolved. Thanks again for your fast answer !

[xPiwel]

Hello @BlackFlash5,

Ok so my bad, after testing and a lots of complains from my players, we still got radio blip sounds and way more often than before.

I've made a new logs save. Here's what I did:

• Connected to my server
• Connected to TeamSpeak server
• I've wait like less than 1 minute and got tons of radio clic sounds.
• Disconnected from the server and saved the logs for you.

I did not even connected to any radio frequency in my session. In this session, I haven't talked with anyone or got closer with anyone in game.

Here are the TS3 and FiveM client logs : https://we.tl/t-LhMKNXQr4V

Waiting for your reply, thanks for your investigations

[BlackFlash5]

Should be fixed in 2.2.1, which is on the testing branch right now. You can update and test. The plugin didn't check the Direct-flag and also played mic clicks for relayed radio communications.

[xPiwel]

Should be fixed in 2.2.1, which is on the testing branch right now. You can update and test.

Alright, I personally updated to 2.2.1 client side on my TeamSpeak. Will try it on and give feedback. If issue is resolved with 2.2.1, will it be on stable branch ? As a lot of my players does not really handle TeamSpeak as you can or I can do, so they won't all be able to go on testing branch correctly if you see what I mean lol

The plugin didn't check the Direct-flag and also played mic clicks for relayed radio communications.

Alright, I see what you mean. Thanks for explaining

[xPiwel]

Hola @BlackFlash5 !

2.2.1 have seems to completly fix the issue of the radio blip sounds. Would it be possible to merge the 2.2.1 from testing to stable branch please ?

Thanks a lot for your fixes ! (Sorry for closing / reopening below, You can close when you've seen this ;) )

[xPiwel]

Hello mate!

I allow myself to remind you on this subject, I did not ask my players to put on the testing version because many will not understand how to install it correctly, lol. But many people ask me if 2.2.1 is coming to stable very soon?

Thank you very much, once again! ♥

[BlackFlash5]

Just brought 2.2.2 to the testing branch, if there are no complaints within the next 24h, it'll be flagged as stable.

[xPiwel]

Just brought 2.2.2 to the testing branch, if there are no complaints within the next 24h, it'll be flagged as stable.

One of my staff member and I just updated to 2.2.2. Will give you a feedback within the next 24h. Thanks!

[xPiwel]

Just brought 2.2.2 to the testing branch, if there are no complaints within the next 24h, it'll be flagged as stable.

Hey! After long day of using 2.2.2, no errors for 2 players and me testing it. Think it's ok for a push on stable branch! :)

[BlackFlash5]

2.2.2 was pushed to stable yesterday. /closed

[xPiwel]

Thank you for all that fixes ! Have a nice week-end.