search

v10networkscom / saltychat-fivem

FiveM implementation of Salty Chat (TeamSpeak 3 based Voice Plugin)
https://gaming.v10networks.com
GNU General Public License v3.0
70 stars 64 forks source link

Player isn't switched after a TeamSpeak crash or forcequit #92

Closed xPiwel closed 2 years ago

xPiwel commented 2 years ago

Describe the issue: Since the latest server update (cloning the v10networkscom/saltychat-fivem repo), when a user crash or force quit TeamSpeak, he can't be switched from the waiting voice channel to the in-game voice channel.

SaltyChat version used on client: Latest stable branch (2.3.6) SaltyChat version used on server: Latest one (all updates are done). Requiered version to connect: 2.3.0

Steps to solve: Quit FiveM and reconnect to the server

Steps to reproduce:

What has been tried: Tried to quit/reopen TeamSpeak | Tried to disconnect from the server and reconnect to the server (TS3 Server). The only thing that works is quit FiveM and reconnect to the server.

Expected behaviour: Switch the user to the voice channel ingame.

Logs (ExtensiveDebug) in attachements, first file is before the TS3 Force quit and second file is when I re-opened TeamSpeak and didn't get switched (I did get switched after relaunching the game).

First log file (before and when I force quited TS3): ts3client_2021-10-15__14_45_34.512478.log

Second log file where I didn't get switched and had to relaunch FiveM to get switched: ts3client_2021-10-15__21_28_31.016224.log

Issue occured to many of my players. I was waiting for logs to make an issue.

Thank you!

BlackFlash5 commented 2 years ago

I couldn't repro this issue, this is also an issue that was fixed before. Does OnDisconnected get triggered in your case? https://github.com/v10networkscom/saltychat-fivem/blob/18f7a258105cf7eafb851020551cee99122fd24d/saltychat/SaltyClient/VoiceManager.cs#L612

xPiwel commented 2 years ago

Resolved.

Line this.PlguinState = GameInstanceState.NotInitiated; wasn't in the OnDisconnect Event, don't know why!

Thanks a lot and sorry for making you loosing some time on this.