search

v17development / flarum-seo

Perfect SEO for your Flarum forum
https://discuss.flarum.org/d/18316-flarum-seo
MIT License
44 stars 20 forks source link

Update PageListener.php #24

Closed os555 closed 4 years ago

os555 commented 4 years ago

Edit function to get dynamic og:image if post has images.

os555 commented 4 years ago

Hi Jasper I am trying to created a new function for setOgimage please review again. :)

nitaaikumar commented 4 years ago

i think @os555 has fixed it. please @jaspervriends could you approve this or something similar so that we can get a proper og:image to show up on facebook, twitter, whatsapp, telegram, etc. for each of our flarum discussions. Thanks.

nitaaikumar commented 4 years ago

Thanks @jaspervriends. For me even this commit is not specifying a clear og:image url for facebook, twitter, whatsapp, telegram, etc. if you could please check it on your forum and further fix or fine tune it to make it work consistently for the og:image, i will be so grateful.

jaspervriends commented 4 years ago

@nitaaikumar I've updated the extension to version 1.1, it should work now. Are you able to try it?

nitaaikumar commented 4 years ago

Thank you @jaspervriends. The og:image is showing up now on Facebook, Telegram etc. Thank you so much for finally fixing this long pending bug. As they say, all is well that ends well.