Infinite loop of same users when loading more

v17development / flarum-user-badges

A Flarum Badges extension

MIT License

16 stars 12 forks source link

Infinite loop of same users when loading more #18

Closed iamdarkle closed 2 years ago

iamdarkle commented 2 years ago

When clicking on a badge to see who has it, if we click on the "load more" button, it starts an infinite loop of the same users.

9uWcmw6 Image by @yuchangye who also reported this bug.

jaspervriends commented 2 years ago

I think this issue is related to this PR https://github.com/flarum/core/pull/3159 (which is already merged), but I am not too sure

iamdarkle commented 2 years ago

That makes a lot of sense (that some external change has affected it indirectly), I mean I just saw the last update of this extension was in June, I'm pretty sure this wasn't happening about 3 months ago when I added some styles to the badges pages.

iamdarkle commented 2 years ago

I have reviewed this and as you pointed out it was probably due to that issue, since this doesn't happen in the latest versions of Flarum, I'm closing 🙂