v1cont / yad

Yet Another Dialog
GNU General Public License v3.0
654 stars 58 forks source link

--button icon regression #185

Closed step- closed 2 years ago

step- commented 2 years ago

Comparing yad_gtk2 with master the following commands show what seems to be a regression when a label is included in the button spec.

# show regression (top right in screenshot)
# I expected to see the yad-no icon
yad_gtk2 --button='gtk2!gtk-yes!tooltip:xdg-open .' & yad --button='master!yad-no!tooltip:xdg-open .' &

# show parity (bottom row in screenshot)
# both yads show their respective button icon + stock label
yad_gtk2 --button='gtk-yes:xdg-open .' & yad --button='yad-no:xdg-open .' &

yad-20220713

Misko-2083 commented 2 years ago

It's not a regression see here L45 yad_stock_items have a label and an image. yad-no is equivalent to "No!gtk-no" so this will work

yad --button='master!gtk-no'
step- commented 2 years ago

@Misko-2083, thank you. I had misunderstood what yad-* icons are for. The source code is clear.