v1s1t0r1sh3r3 / airgeddon

This is a multi-use bash script for Linux systems to audit wireless networks.
GNU General Public License v3.0
6.46k stars 1.17k forks source link

Update italian language #619

Closed zonalimitatore closed 1 month ago

zonalimitatore commented 1 month ago

Update italian language

OscarAkaElvis commented 1 month ago

Why are you modifying strings from other languages?

image

That is a string that changed slightly. Obviously, you were working over an outdated version. You should update to the latest before the PR, or fix the broken stuff doing another commit on this PR. Otherwise, it will be rejected.

cc @salu90 as reviewer.

OscarAkaElvis commented 1 month ago

Also breaking indentation

image

Sorry but you need to be very meticulous to collaborate in airgeddon. Fix every single space or broken tab or it will be rejected. If you are modifying italian strings, you must be modifying ONLY that... no spaces, no tabs and of course, no other language strings.

Now you need to be very accurate on your next commit to fix everything to their initial state but italian strings or it will be rejected. We are not here to fix other users' lack of attention.

zonalimitatore commented 1 month ago

I didn't change anything except the Italian language. I took the file directly from the dev section. I had done and tested work up to 1.30. In 1.40 there were only 2 more lines to change, nothing more.

OscarAkaElvis commented 1 month ago

I think you are not realizing about what happened here. I'll try to explain it for you.

  1. You forked the repo and get the dev branch
  2. While you have your forked repo, airgeddon original repo changed... some language strings like string et_misc_texts 28 changed from "Portal access" to "Portal accessed" in all languages and probably others.
  3. You modify your stuff in your obsolete version without updating it with the original repo's new content
  4. You do a PR and the result is this and my comment is because of that.

The test is simple, and my screenshots are the proof about what I'm saying. Check what string et_misc_texts 28 contains in your repo and check what is in the airgeddon's dev branch... it is different. Now if you try to put your stuff on dev, you are overwritting some strings and that is the cause that you are modifying other languages, the lack of updating... so or you fix all the stuff you are breaking doing another commit or we must reject the PR, sorry. You should get airgeddon's dev language string file and your file and do a diff... get the differences... and all modified stuff different than the italian strings is an error.

If you don't know how to fix this because you are not skilled using git, you can close the PR and fork again, update, do your stuff again and do PR again... but is a lot of work. I think that git stuff is better to learn... so check over the internet about how to fix that stuff using git commands.

zonalimitatore commented 1 month ago

I've this: et_misc_texts["ENGLISH",28]="Portal access" et_misc_texts["SPANISH",28]="Acceso al portal" et_misc_texts["FRENCH",28]="\${pending_of_translation} Accès au portail" et_misc_texts["CATALAN",28]="\${pending_of_translation} Accés al portal" et_misc_texts["PORTUGUESE",28]="\${pending_of_translation} Acesso ao portal" et_misc_texts["RUSSIAN",28]="\${pending_of_translation} Доступ к порталу" et_misc_texts["GREEK",28]="\${pending_of_translation} Πρόσβαση στην πύλη" et_misc_texts["ITALIAN",28]="\${pending_of_translation} Accesso al portale" et_misc_texts["POLISH",28]="\${pending_of_translation} Dostęp do portalu" et_misc_texts["GERMAN",28]="\${pending_of_translation} Portalzugang" et_misc_texts["TURKISH",28]="\${pending_of_translation} Portal erişimi" et_misc_texts["ARABIC",28]="\${pending_of_translation} الوصول إلى البوابة" et_misc_texts["CHINESE",28]="\${pending_of_translation} 门户访问"