v2fly / domain-list-community

Community managed domain list. Generate geosite.dat for V2Ray.
https://www.v2fly.org
MIT License
4.98k stars 905 forks source link

Solve multiple root node problem and decrease it #1561

Closed rootmelo92118 closed 1 year ago

rootmelo92118 commented 1 year ago

I write a script to find the categories which are not included by other categories. And I get this result.

category-finance
adobe-activation
category-network-security
speedtest
pandanet
test
category-pt
category-ads-all
cn
category-public-tracker
cowlevel
biliplus
tld-opennic
chemequations
dslreports
private
tor
apple-update
category-enhance-gaming
showtimeanytime
geolocation-!cn
category-ir
downloadly
category-ru-gov
hubblephone

Some categories should not be included by others. That is according to the discussion with other collaborators so I won't touch them. Besides, I will create some pull requests to include them in others.

IceCodeNew commented 1 year ago

Would you mind me postponing the review till April? (Thank god it is not the mega PR you mentioned in the private chat, I think I might be able to make a call for all of this by the end of today. And I still think the following suggest might be helpful, so I will just leave them) It is indeed a good idea, but I think I can only make a call when I have time to review all of this; Digesting them one by one may lead to misunderstanding and a lapse in judgment.

BTW, you did it very well in splitting the changes into several small PRs. However, you could make it better by just opening this issue, and waiting till you have had a discussion with people who is likely to review the PRs. You can start your work after you have put some effort to make sure that any overlooking has been caught in advance, and reviewers show interest in your proposal. @rootmelo92118

rootmelo92118 commented 1 year ago

Oh, I am sorry to make you misunderstand. For these categories, my strategy is to include them in existing categories. If you think it should not belong to some categories, welcome to make a discussion. @IceCodeNew

IceCodeNew commented 1 year ago

The newest ETA is the coming Saturday night, thanks for everyone being patient.

IceCodeNew commented 1 year ago

Finally, I can have some rest...