search

v2fly / fhs-install-v2ray

Bash script for installing V2Ray in operating systems such as Debian / CentOS / Fedora / openSUSE that support systemd
GNU General Public License v3.0
6.29k stars 1.46k forks source link

Update install-dat-release.sh #305

Closed i3dx closed 3 weeks ago

i3dx commented 1 month ago

-p, --preserve-timestamps apply access/modification times of SOURCE files to corresponding destination files

IceCodeNew commented 3 weeks ago

增加额外的选项可能会导致在一些系统上遇到兼容性问题（比如 busybox 提供的 install 二进制参数就和 GNU binutils 提供的不完全一致 有具体的使用场景一定需要加这个选项吗？

Adding extra options may lead to compatibility issues on some systems (for example, the install binary parameters provided by BusyBox are not entirely consistent with those from GNU Binutils). Is there a specific use case that requires this option?

i3dx commented 3 weeks ago

通过geo文件的修改日期可以快速判断是否需要更新。

The modification date of the geo file can quickly indicate whether an update is needed.

IceCodeNew commented 3 weeks ago

通过geo文件的修改日期可以快速判断是否需要更新。

The modification date of the geo file can quickly indicate whether an update is needed.

这样还不如通过记录 etag 来判断是否需要跳过更新呢。如果你有兴趣换一种思路（不一定使用 etag，你可以继续和我讨论其他的思路），我很欢迎你的 pr 就现在的修改来说，我觉得引入的风险大于收益。我会关闭这个 PR，后续可以新开一个 issue 继续讨论