Open GoogleCodeExporter opened 9 years ago
Could you please upload the patch to codereview.appspot.com. From my POV it
looks nice, but maybe someone else on the developer list has some comments :)
BTW, have you already signed a Individual Contributor License Agreement (see
http://code.google.com/p/rietveld/wiki/Contributing under "Legal Stuff" for
deails)?
Original comment by albrecht.andi
on 21 Jan 2012 at 8:02
No I have not signed the agreement. Have to do that at some point. Also I have
not uploaded the patch either, it still has flaws with binary files. The patch
only solves problems when adding a new binary image but the upload still fails
for us when we try to upload a modified binary. We hacked an ugly try except
into the upload.py to make it work but don't see it as a final solution.
Original comment by sportjun...@gmail.com
on 8 Feb 2012 at 4:35
Thanks for the feedback! Let us know when you've a patch ready for review!
Original comment by albrecht.andi
on 9 Feb 2012 at 1:59
Original comment by albrecht.andi
on 6 Apr 2012 at 6:31
Original issue reported on code.google.com by
sportjun...@gmail.com
on 29 Dec 2011 at 6:24Attachments: