v3ss0n / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

Usability issue: no mail sent when reviewers added in "Edit issue" form #372

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
I just spent some time helping a user track an issue where they thought mail 
was being dropped. (See the last few comments in issue 346.) After various 
tests the user realized that they were editing the issue in order to add a 
reviewer and expected that upon submitting that form the reviewer would receive 
an email. We could fix this by sending email in this case, but IIRC we thought 
about that and decided that we should *not* be sending mail in that case. So 
perhaps a better response might be to add a note somewhere to the form 
reminding the user that no mail will be sent and to use Publish+Mail to send 
email.

Original issue reported on code.google.com by guido@google.com on 23 Feb 2012 at 1:27

GoogleCodeExporter commented 9 years ago
It is interesting to know why not? In Trac it is not only convenient to receive 
such notifications, but also to browse history of such changes.

Original comment by techtonik@gmail.com on 23 Feb 2012 at 10:58

GoogleCodeExporter commented 9 years ago
I would actually be fine with sending email in such cases. We'd need a "send 
email" checkbox that is on by default so that a careful developer can suppress 
a needless email for a trivial change. FWIW I wasn't going to implement this 
myself, be my guest if you feel like it.

We migh change upload.py to also always send email.

Original comment by guido@google.com on 23 Feb 2012 at 3:06

GoogleCodeExporter commented 9 years ago

Original comment by albrecht.andi on 6 Apr 2012 at 6:20