v3ss0n / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

"Start Review" gives 404 Not Found #373

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Upload a changeset with upload.py, such that the first diff listed is 
mergeinfo for "."
2. Click "Start Review".

What is the expected output? What do you see instead?
I expected to see the diff for the . mergeinfo change. 

Instead, I get a 404 Not Found.

I can successfully see this diff by clicking the link in the list of diffs. 
That link is http://<our domain>/<issue ID>/patch/1/79, and it works. However, 
the "Start Review" link is to http://<our domain>/<issue ID>/diff/1/, which 
fails.

What browser are you using?  What version? On what operating system?
I have this issue in Firefox 10.0.2, but have seen it since Firefox 3.6. Other 
members of my company also experience it in various versions of Chrome and 
Safari.

At what URL are you accessing Rietveld?  (e.g. codereview.appspot.com)
Please note if you are using the Google Apps Labs version (e.g.
codereview.<yourdomain>).

Apps Labs version @ http://codereview.clockwork.net. I am not a google employee.

Please provide any additional information below.

We use a slightly modified version of upload.py that is adapted to our 
workflow, so I do not know if something about the diff that is created is 
unique. I'm happy to help test a vanilla version if that would be useful.

Original issue reported on code.google.com by eryn.oneil@gmail.com on 1 Mar 2012 at 11:01

GoogleCodeExporter commented 9 years ago

Original comment by albrecht.andi on 3 Mar 2012 at 9:13

GoogleCodeExporter commented 9 years ago

Original comment by albrecht.andi on 6 Apr 2012 at 6:31

GoogleCodeExporter commented 9 years ago
How do you get a file named "."?

Original comment by jrobbins@google.com on 11 Jul 2014 at 11:41

GoogleCodeExporter commented 9 years ago
@jrobbins@google.com: If the diff includes mergeinfo changes on the top 
directory.

Example:

Property changes on: .
___________________________________________________________________
Modified: svn:mergeinfo
Merged /code/products/abc/trunk:r143485-144118

Original comment by eryn.oneil@gmail.com on 16 Jul 2014 at 4:06