search

v3ss0n / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

upload.py should use OAuth 2.0 #385

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
ClientLogin is deprecated; see 
https://developers.google.com/accounts/docs/AuthForInstalledApps

upload.py should switch to using OAuth 2.0 instead.

Original issue reported on code.google.com by mdemp...@google.com on 2 Jun 2012 at 1:13

GoogleCodeExporter commented 9 years ago 
I'd be happy to do this.

Original comment by dhermes@google.com on 22 Jan 2013 at 1:39

GoogleCodeExporter commented 9 years ago 
Seems easy enough - 
https://github.com/GoogleCloudPlatform/storage-oauth2-tool-python

Original comment by techtonik@gmail.com on 24 Jan 2013 at 10:53

GoogleCodeExporter commented 9 years ago 
Since ClientLogin is deprecated, we should do something until somewhere in 2014.

But I find it quite important that we are able to communicate with the server 
without any additional dependencies other than what comes with the Python 
standard library.

It seems quite common that projects which use Rietveld just place a copy of 
upload.py (eventually with some project-specific customizations) in their 
"tools" folder and it just works without any additional setup. IMO it would be 
great if we could keep this working that way.

Original comment by albrecht.andi on 24 Jan 2013 at 11:26

GoogleCodeExporter commented 9 years ago 
I am +1 for self-sufficient upload.py

Original comment by techtonik@gmail.com on 24 Jan 2013 at 1:19

GoogleCodeExporter commented 9 years ago 
Yes, that's my plan. Most of the niceties of google-api-python-client can be 
stripped away.

Original comment by dhermes@google.com on 24 Jan 2013 at 5:39

GoogleCodeExporter commented 9 years ago 
The server side part has begun in:
https://codereview.appspot.com/7326049

Original comment by dhermes@google.com on 15 Feb 2013 at 10:09

GoogleCodeExporter commented 9 years ago 
RE: Andi Albrecht comment about adding a copy of upload.py, it's fairly easy to 
distribute an entire package as an executable by zipping up a folder, so long 
as that folder contains a __main__.py file.

Original comment by dhermes@google.com on 15 Feb 2013 at 10:12

GoogleCodeExporter commented 9 years ago 
Isn't this now Fixed?

Original comment by kpreid.switchb.org on 10 May 2013 at 12:45

GoogleCodeExporter commented 9 years ago 
Indeed. w00t!

Original comment by dhermes@google.com on 10 May 2013 at 1:47

GoogleCodeExporter commented 9 years ago

Original comment by albrecht.andi on 10 May 2013 at 4:10