v3ss0n / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

Allow apostrophes & other special characters in nickname #399

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
My last name has had an apostrophe since some time before Rietveld existed, and 
I'm not planning on changing it soon.

Unfortunately Rietveld doesn't allow my to use my last name as my nickname (it 
only allows letters, digits, ".-_()" and spaces). This causes problems for some 
of my colleagues who need to refer to me by nickname in commit messages.

Original issue reported on code.google.com by dharcourt@chromium.org on 10 Oct 2012 at 7:40

GoogleCodeExporter commented 9 years ago
Looks like a can of worms with quoting to me. Why do you need to change your 
last name? Why not just change the nick to be compatible with notation of email 
address?

Original comment by techtonik@gmail.com on 15 Oct 2012 at 7:25

GoogleCodeExporter commented 9 years ago
Since Rietveld doesn't support '@' in nicknames it's not possible for me to use 
my email address as my nickname. I'm changing it to be my work username as 
that's the least bad option I can think of, but I expect co-workers who know me 
by my real name in real life and by my email address online will continue to 
find it annoying that Rietveld knows me by another name. It's because one of 
them came up to me and complained that I submitted this bug repot in the first 
place.

Isn't Rietveld already quoting all strings before display or use in queries? 
Most web and database frameworks do that automatically, and it would be a 
security problem waiting to happen if it doesn't.

In any case, I would recommend that Rietveld does what it takes to support a 
fuller range of characters in user nicknames. Apart from anything else not 
doing that reflects badly on Rietveld, and by extension on the Python 
technologies it is based on. My personal experience is that even the most 
backward computer systems have started supporting the full range of ASCII 
characters in names and other user input within the last 10 years or so.

Original comment by dharcourt@chromium.org on 15 Oct 2012 at 5:11

GoogleCodeExporter commented 9 years ago
Charles, if you want this to be resolved you will have to implement it.

Original comment by maruel@chromium.org on 16 Oct 2013 at 4:35