v3ss0n / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

Side-by-side diff is wrong #403

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?

Compare the unified diff at https://codereview.chromium.org/11280126/patch/1/4 
to the side-by-side diff at 
https://codereview.chromium.org/11280126/diff/1/chrome/browser/ui/constrained_wi
ndow.cc.

The latter interprets the diff as duplicating the GetLinkColor function, which 
is incorrect.

What browser are you using?  What version? On what operating system?

Chrome 23.0.1271.64 on Windows 7/x64.  Rietveld 946:6b0723885b3e.

*** If you are a Google employee please say so or mail me (Guido van
Rossum) directly. ***

I am a Google employee.

Please provide any additional information below.

Original issue reported on code.google.com by wittman@chromium.org on 21 Nov 2012 at 7:51

GoogleCodeExporter commented 9 years ago
I've never seen something similar on codereview.appspot.com. Could this issue 
be related to patiencediff used in chromium branch?

Original comment by albrecht.andi on 21 Nov 2012 at 8:22

GoogleCodeExporter commented 9 years ago
Thanks Andi, cc'ing the other Marc-Antoine.

See the raw diff;
https://codereview.chromium.org/download/issue11280126_1_4.diff

Original comment by maruel@chromium.org on 21 Nov 2012 at 8:50

GoogleCodeExporter commented 9 years ago
Seems like I can't mark the issue as fixed (not a project member), but it's 
been fixed:
https://codereview.appspot.com/7312077/

Original comment by macourt...@chromium.org on 11 Feb 2013 at 7:18

GoogleCodeExporter commented 9 years ago
Verified the fix works.

Original comment by maruel@chromium.org on 11 Feb 2013 at 7:22