search

v3ss0n / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

svg files should be reviewed as text #450

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Currently, the isImage check in upload.py looks at the mimetype to determine if 
a file is likely an image.  Since svg files are "image/svg", it returns true, 
and then tries to display the file as in img tag in diff view.

We should exclude image/svg and treat as text files.

Related Chromium bug: https://code.google.com/p/chromium/issues/detail?id=247791

Original issue reported on code.google.com by jparent@chromium.org on 7 Jun 2013 at 9:04

GoogleCodeExporter commented 9 years ago 
Committed as revision a064225f2ab3.
Review: https://codereview.appspot.com/10117044/

Original comment by albrecht.andi on 8 Jun 2013 at 4:24