v3ss0n / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

Include log description (commit message) as a file to be reviewed in Rietveld #457

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
The log message (description) of a change is important (particularly for some 
project's cultures), but reviewers often forget to review it, or if they do, it 
is awkward to do.

Gerrit solves this by adding a magic file to all patchsets, so it can be 
reviewed with per-line comments.  This also allows you to see how it changes 
over time, rather than only showing the current version.

Chromium bug on the issue: 
https://code.google.com/p/chromium/issues/detail?id=169249

I'm working on this now, would love feedback from Rietveld-land if anyone 
thinks this is a bad idea, and I'll put it into Chromium directly (this is a 
big feature request for us).

Original issue reported on code.google.com by jparent@chromium.org on 22 Jul 2013 at 11:27

GoogleCodeExporter commented 9 years ago
Love the idea. I've noticed this too.

Original comment by gvanrossum@gmail.com on 22 Jul 2013 at 11:31