search

v6d-io / v6d

vineyard (v6d): an in-memory immutable data manager. (Project under CNCF, TAG-Storage)
https://v6d.io
Apache License 2.0
829 stars 122 forks source link

Replace Tensor and TensorBuilder with the KVTensor and KVTensorBuilder to delete the arrow deps. #1819

Closed dashanji closed 6 months ago

dashanji commented 6 months ago

What do these changes do?

Before:

$ ldd libvineyard_llm_cache.so | grep arrow
libarrow.so.1500 => /lib/x86_64-linux-gnu/libarrow.so.1500 (0x00007f5da9879000)

Now:

$ ldd libvineyard_llm_cache.so | grep arrow

Related issue number

Fixes https://github.com/v6d-io/v6d/issues/1818

vegetableysm commented 6 months ago

It might be better to change the filename to the class name. e.g. kv_state_cache_blob.h -> KVTensor.h

dashanji commented 6 months ago

It might be better to change the filename to the class name. e.g. kv_state_cache_blob.h -> KVTensor.h

Make sense to me. Updated to kv_tensor.h to keep the same naming form such as kv_state_cache.h