v7labs / darwin-py

Library and commandline tool for managing datasets on darwin.v7labs.com
MIT License
115 stars 42 forks source link

Update utils.py line 576 #786

Closed gerdac closed 4 months ago

gerdac commented 7 months ago

update to line 576

image_path = get_image_path_from_stream(darwin_json, images_dir, with_folders = 0, annotation_filepath = annotation_path)

Problem

Unable to use trainer because the following error is thrown: TypeError: get_image_path_from_stream() missing 2 required positional arguments: 'with_folders' and 'annotation_filepath'

get_image_path_from_stream() command requires all 4 inputs. It does not work otherwise.

Solution

included the arguments 'with_folders' and 'annotation_filepath'

Changelog

(Will appear in release docs)

JBWilkie commented 4 months ago

Hi @gerdac, I apologise for the significant delay here! However, I'm happy to report that the latest version of darwin-py (1.0.0) made some significant changes to the way we name and read local files. You can read about them here. Part of this work resolved this issue with the missing arguments in this call of the get_image_path_from_stream() function.