v7labs / darwin-py

Library and commandline tool for managing datasets on darwin.v7labs.com
MIT License
115 stars 42 forks source link

[DAR-1609][External] pull() never creates the properties metadata file in the annotations directory #816

Closed JBWilkie closed 4 months ago

JBWilkie commented 4 months ago

Problem

When downloading annotation ZIPs when using pull(), the properties manifest file is never created in the annotations directory. This is because despite the fact that we download the same ZIP file that the frontend provides, we first unzip the files in a temporary directory, then only move .json files to the annotations directory. This leaves the .v7 folder behind

Solution

If the properties metadata file is present, move it to the annotations directory

Changelog

Fixed a bug where downloading annotations with darwin-py would not include the properties metadata file

linear[bot] commented 4 months ago

DAR-1609 BUG: When pulling exports with darwin-py, the .v7/metadata.json file is never created in the annotation directory

saurbhc commented 4 months ago

Let's also add a test case, maybe here? - which makes sure it moves the metadata.json file